docs: remove a description about the outdated way of overriding query #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
reviewed
Oct 31, 2023
amaanq
approved these changes
Oct 31, 2023
|
The whole readme is an obsolete mess... I've refrained from touching it to avoid (more) rebase conflicts on the |
This saying that "all queries found in the runtime directories will be combined" was true prior to 0.8.0, but since neovim/neovim#20117 query files are no longer concatenated but the first query file on runtimepath will be used. This documentation section has already been fixed in the `main` branch but we still have to correct the wrong, outdated information for the current versions of neovim and nvim-treesitter until it becomes the new default.
|
Will this be merged? |
|
Just wanted to say that I think it would be nice if this was merged, since right now what is said in the Readme is wrong (which is kind of worse than no documentation at all). I don't know about the 1.0 timeline, but if significantly modifying the current (master branch) Readme is really not an option, maybe just put a big fat warning at the top that it's partly outdated? I think it would be very helpful, at least for me if would have been. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saying that "all queries found in the runtime directories will be
combined" was true prior to 0.8.0, but since neovim/neovim#20117 query
files are no longer concatenated but the first query file on runtimepath
will be used.
This documentation section has already been fixed in the
mainbranchbut we still have to correct the wrong, outdated information for the
current versions of neovim and nvim-treesitter until it becomes the new
default.
(The old docs was written in 2021 for neovim 0.7.x, see #2011)