-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use tree-sitter build #6496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clason
force-pushed
the
feat/tsbuild
branch
2 times, most recently
from
April 23, 2024 12:25
56e4204
to
41f92e9
Compare
clason
force-pushed
the
main
branch
2 times, most recently
from
April 25, 2024 10:09
17e2df8
to
fd2c8e2
Compare
clason
force-pushed
the
main
branch
6 times, most recently
from
April 27, 2024 08:43
a0482fa
to
5e807d7
Compare
clason
force-pushed
the
main
branch
6 times, most recently
from
April 27, 2024 12:41
1700fc7
to
5ce9c89
Compare
clason
force-pushed
the
main
branch
4 times, most recently
from
May 7, 2024 07:34
8e1e2ee
to
124d0f6
Compare
clason
force-pushed
the
main
branch
3 times, most recently
from
May 9, 2024 09:12
2b3cda7
to
4a73dbb
Compare
clason
force-pushed
the
main
branch
2 times, most recently
from
May 11, 2024 07:36
324b8aa
to
545f893
Compare
clason
force-pushed
the
feat/tsbuild
branch
2 times, most recently
from
May 11, 2024 16:15
51bc830
to
77d5d5c
Compare
clason
force-pushed
the
main
branch
2 times, most recently
from
May 12, 2024 08:48
7a3f76e
to
8512fc9
Compare
clason
force-pushed
the
feat/tsbuild
branch
2 times, most recently
from
May 12, 2024 09:47
7b72808
to
a1f46f7
Compare
clason
force-pushed
the
main
branch
3 times, most recently
from
May 14, 2024 06:55
f298b19
to
a786c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick test to compare build times on CI:
network/load adds large variance, but the windows improvement is significant (and welcome on CI).
Also, adding or removing scanners is no longer a breaking change.
Also also, look at those diffstats 🤩
Notes on possible (upstream) improvements:
ts b
litters debug symbols in the build directory.generate
andbuild
step ifts b
generated if necessary. For our purposes, though, we'd need more control:ts b
builds fromparser.c
ts b src/grammar.json
callsts g src/grammar.json
firstts b grammar.js
callsts g
first(and
ts b
would need to take all flags forts g
as well).