Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use tree-sitter build #6496

Merged
merged 1 commit into from
May 16, 2024
Merged

feat!: use tree-sitter build #6496

merged 1 commit into from
May 16, 2024

Conversation

clason
Copy link
Contributor

@clason clason commented Apr 22, 2024

quick test to compare build times on CI:

  • ubuntu: 2:09 vs 1:50
  • macos: 1:40 vs 1:20 (locally, 95s vs 85s)
  • windows: 3:55 vs 5:09

network/load adds large variance, but the windows improvement is significant (and welcome on CI).

Also, adding or removing scanners is no longer a breaking change.

Also also, look at those diffstats 🤩

Notes on possible (upstream) improvements:

  1. Ideally, we could build directly into the target location, obviating the need for the move task, but ts b litters debug symbols in the build directory.
  2. We could combine generate and build step if ts b generated if necessary. For our purposes, though, we'd need more control:
  • ts b builds from parser.c
  • ts b src/grammar.json calls ts g src/grammar.json first
  • ts b grammar.js calls ts g first

(and ts b would need to take all flags for ts g as well).

@clason clason changed the title feat: use tree-sitter build feat!: use tree-sitter build Apr 22, 2024
@clason clason added the NEXT Issues or PRs targeting the nvim-treesitter 1.0 rewrite label Apr 22, 2024
@clason clason force-pushed the feat/tsbuild branch 2 times, most recently from 56e4204 to 41f92e9 Compare April 23, 2024 12:25
@clason clason force-pushed the main branch 2 times, most recently from 17e2df8 to fd2c8e2 Compare April 25, 2024 10:09
@clason clason force-pushed the main branch 6 times, most recently from a0482fa to 5e807d7 Compare April 27, 2024 08:43
@clason clason force-pushed the main branch 6 times, most recently from 1700fc7 to 5ce9c89 Compare April 27, 2024 12:41
@clason clason force-pushed the main branch 4 times, most recently from 8e1e2ee to 124d0f6 Compare May 7, 2024 07:34
@clason clason force-pushed the main branch 3 times, most recently from 2b3cda7 to 4a73dbb Compare May 9, 2024 09:12
@clason clason force-pushed the main branch 2 times, most recently from 324b8aa to 545f893 Compare May 11, 2024 07:36
@clason clason force-pushed the feat/tsbuild branch 2 times, most recently from 51bc830 to 77d5d5c Compare May 11, 2024 16:15
@clason clason force-pushed the main branch 2 times, most recently from 7a3f76e to 8512fc9 Compare May 12, 2024 08:48
@clason clason force-pushed the feat/tsbuild branch 2 times, most recently from 7b72808 to a1f46f7 Compare May 12, 2024 09:47
@clason clason force-pushed the main branch 3 times, most recently from f298b19 to a786c73 Compare May 14, 2024 06:55
@clason clason merged commit 5f717cc into main May 16, 2024
6 of 7 checks passed
@clason clason deleted the feat/tsbuild branch May 16, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEXT Issues or PRs targeting the nvim-treesitter 1.0 rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants