New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache for get_query function #879
Merged
vigoux
merged 12 commits into
nvim-treesitter:master
from
oberblastmeister:cache-queries
Jan 28, 2021
Merged
Add cache for get_query function #879
vigoux
merged 12 commits into
nvim-treesitter:master
from
oberblastmeister:cache-queries
Jan 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theHamsta
reviewed
Jan 27, 2021
theHamsta
reviewed
Jan 27, 2021
oberblastmeister
changed the title
Add cache to get_query function
Add cache for get_query function
Jan 27, 2021
vigoux
reviewed
Jan 28, 2021
vigoux
reviewed
Jan 28, 2021
Co-authored-by: Thomas Vigouroux <tomvig38@gmail.com>
Co-authored-by: Thomas Vigouroux <tomvig38@gmail.com>
|
No I don't think it is worth changing now, or rather, we'll look into it later. |
vigoux
approved these changes
Jan 28, 2021
Thanood
pushed a commit
to Thanood/nvim-treesitter
that referenced
this pull request
Apr 14, 2021
* added cached to get_query * added reload function * fixed message * added autocommand to reload cache on bufwrite for query file * pass filename to autocommand v:lua fn * removed comment * added metatable * fixed loop * Update lua/nvim-treesitter/query.lua Co-authored-by: Thomas Vigouroux <tomvig38@gmail.com> * Update lua/nvim-treesitter/query.lua Co-authored-by: Thomas Vigouroux <tomvig38@gmail.com> * added do ... end to local query_cache * made line shorter Co-authored-by: Thomas Vigouroux <tomvig38@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is putting the cache inside of a
do ... end
block the right choice?