Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10m populated places fix wikidataids #457

Merged
merged 69 commits into from
Mar 4, 2021

Conversation

mizmay
Copy link
Collaborator

@mizmay mizmay commented Dec 29, 2020

Connects to #419, #453, #449, #411, #406, #339, #405, #373, #365, #358, #356, #334, #330, #323, #318, #389, #388, #387, #385, #384, #383, #381, #377, #371, #368, #367, #364, #362, #310, #293.

This PR partially or fully addresses over 30 issues. The goal here is to make the changes necessary in advance of batch updates to default and localized names. The only really necessary change I know of is to update wikidataids and add new features, but since updating FEATURECLA can happen independently, I addressed issues around changes to designation as Populated place, Admin-1 capital or Admin-0 capital as well.

Modifications to 10m_Populated_Places in keeping with Step 1 and Step 2, outlined in this gist.

An additional large chunk of open issues (25+) can be addressed once localized name_* values are updated based on wikidataids, leaving the path clear for additional batch processes and/or manual edits to individual records.

  1. Script documents changes to wikidataids to support overwriting default NAME, NAMEASCII, and localized name_* fields based on values from wikidata.
  2. CSV lists the full attributes for the records with revised wikidataid

@mizmay mizmay force-pushed the 10m-populated-places-fix-wikidataids branch from 37cced4 to ab20e6a Compare December 29, 2020 21:11
@mizmay mizmay force-pushed the 10m-populated-places-fix-wikidataids branch from 993e345 to 271643b Compare December 29, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants