-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10m populated places fix wikidataids #457
Merged
nvkelso
merged 69 commits into
nvkelso:master
from
mizmay:10m-populated-places-fix-wikidataids
Mar 4, 2021
Merged
10m populated places fix wikidataids #457
nvkelso
merged 69 commits into
nvkelso:master
from
mizmay:10m-populated-places-fix-wikidataids
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37cced4
to
ab20e6a
Compare
ab20e6a
to
0d14e63
Compare
This was referenced Dec 29, 2020
993e345
to
271643b
Compare
This was referenced Mar 4, 2021
This was referenced Mar 6, 2021
This was referenced Mar 7, 2021
This was referenced Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #419, #453, #449, #411, #406, #339, #405, #373, #365, #358, #356, #334, #330, #323, #318, #389, #388, #387, #385, #384, #383, #381, #377, #371, #368, #367, #364, #362, #310, #293.
This PR partially or fully addresses over 30 issues. The goal here is to make the changes necessary in advance of batch updates to default and localized names. The only really necessary change I know of is to update wikidataids and add new features, but since updating
FEATURECLA
can happen independently, I addressed issues around changes to designation asPopulated place
,Admin-1 capital
orAdmin-0 capital
as well.Modifications to 10m_Populated_Places in keeping with Step 1 and Step 2, outlined in this gist.
An additional large chunk of open issues (25+) can be addressed once localized name_* values are updated based on wikidataids, leaving the path clear for additional batch processes and/or manual edits to individual records.
wikidataid
s to support overwriting defaultNAME
,NAMEASCII
, and localizedname_*
fields based on values from wikidata.wikidataid