Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global query: wrong input transformation #13

Closed
shkarupa-alex opened this issue Jul 7, 2022 · 1 comment
Closed

Global query: wrong input transformation #13

shkarupa-alex opened this issue Jul 7, 2022 · 1 comment

Comments

@shkarupa-alex
Copy link
Contributor

Here https://github.com/NVlabs/GCVit/blob/main/models/gc_vit.py#L382 "x" is features in channel-last format [batch, height, width, channels]
You passing it thru some Conv2D layers (FeatExtract) which work with features in channel-first format ([batch, height, width, channels]). But instead of transpose operation you are making reshape with mixes channels and spatial axis.

shkarupa-alex added a commit to shkarupa-alex/GCVit that referenced this issue Jul 7, 2022
@ahatamiz
Copy link
Collaborator

ahatamiz commented Jul 7, 2022

@shkarupa-alex Thanks for the comment. It will be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants