Skip to content

Commit

Permalink
Update install.sh
Browse files Browse the repository at this point in the history 
$HOME/.nvm used instead of introduced earlier NVM_TARGET.
  • Loading branch information
@witoldsz
witoldsz committed Dec 4, 2012
1 parent 59c8eda commit 2f6b0ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install.sh
View file
Expand Up @@ -25,7 +25,7 @@ else
fi
fi

SOURCE_STR='[[ -s "$HOME/.nvm/nvm.sh" ]] && . "$HOME/.nvm/nvm.sh" # This loads NVM'
SOURCE_STR='[[ -s "$NVM_TARGET/nvm.sh" ]] && . "$NVM_TARGET/nvm.sh" # This loads NVM'

This comment has been minimized.

Sign in to view

Copy link
@koenpunt

koenpunt Dec 4, 2012

Contributor

$NVM_TARGET does not expand to the variable set in the script, so the line appears as following in your profile:

[[ -s "$NVM_TARGET/nvm.sh" ]] && . "$NVM_TARGET/nvm.sh" # This loads NVM

if [ -z "$PROFILE" ] || [ ! -f "$PROFILE" ] ; then
if [ -z $PROFILE ]; then
Expand Down

1 comment on commit 2f6b0ca

@witoldsz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, you are right.
I was thinking, maybe the NVM_TARGET should be assigned only when it is unset. That would allow users to launch install script with NVM_TARGET being preset to location of their own... or... the install location could be the parameter of the script.

Please sign in to comment.