Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt this command to install version as well #1272

Closed
kirkstrobeck opened this issue Oct 24, 2016 · 3 comments
Closed

Adapt this command to install version as well #1272

kirkstrobeck opened this issue Oct 24, 2016 · 3 comments
Labels
informational pull request wanted This is a great way to contribute! Help us out :-D

Comments

@kirkstrobeck
Copy link

Currently the script at https://github.com/creationix/nvm/#zsh fails silently if not previously installed. It should prompt the use to auto-install or simply auto-install.
@ljharb
Copy link
Member

ljharb commented Oct 24, 2016

Sure, that can be fixed by swapping nvm use for nvm install.

@ljharb ljharb added informational pull request wanted This is a great way to contribute! Help us out :-D labels Oct 24, 2016
PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this issue Nov 14, 2016
@PeterDaveHello
Auto install not exist version in zsh .nvmrc script, close nvm-sh#1272
447539e
@PeterDaveHello
Copy link
Collaborator

PR sent in #1306

@PeterDaveHello
Copy link
Collaborator

@kirkstrobeck would you like to take a look at #1306 see if it helps? Thanks.

@ljharb ljharb mentioned this issue Nov 18, 2016
Merged
PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this issue Nov 18, 2016
@PeterDaveHello
Auto install not exist version in zsh .nvmrc script, close nvm-sh#1272
416b691
PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this issue Nov 18, 2016
@PeterDaveHello
Auto install not exist version in zsh .nvmrc script, close nvm-sh#1272
50fb098
@ljharb ljharb closed this as completed in e47b313 Nov 24, 2016
@lukechilds lukechilds mentioned this issue Jan 3, 2017
Closed
edwmurph pushed a commit to edwmurph/nvm that referenced this issue Apr 9, 2018
@PeterDaveHello @ljharb
[readme] Auto install not exist version in zsh .nvmrc script
feacd90 
Fixes nvm-sh#1272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
informational pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @kirkstrobeck @PeterDaveHello