bash_completion file is not dowloaded when installing via install.sh (METHOD=script)

[matskiv]

• Operating system and version:
  macOS 10.12.5

• How did you install nvm? (e.g. install script in readme, homebrew):
  install script (METHOD=script)

• What steps did you perform?

$ curl https://raw.githubusercontent.com/creationix/nvm/v0.33.2/install.sh > nvm_install.sh
$ chmod +x nvm_install.sh 
$ export METHOD=script
$ ./nvm_install.sh
...
$ ls .nvm/
nvm-exec	nvm.sh

• What happened?
  Only nvm-exec and nvm.sh were downloaded.
• What did you expect to happen?
  $NVM_DIR/bash_completion should have been downloaded as well. It's referenced in .bashrc, and source .bashrc exits with code 1 because its missing.
• Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
  Just this in .bashrc:

export PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
export LANG=en_US.UTF-8

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

[ljharb]

[ -s "$NVM_DIR/bash_completion" ] ensures that if it doesn't exist, it won't evaluate the rest of the line; that shouldn't make things exit unless you've enabled set -e (which doesn't belong in a bashrc file, that's for sure).

Indeed, the script method only downloads nvm.sh and nvm-exec; I suppose we could add bash_completion too.

[matskiv]

My problem was because this check: [ -s "$NVM_DIR/bash_completion" ] was on last line, and when bash_completion wasn't there it affected exit code of source .bashrc.

@ljharb Thank you for the fix. 👍
Btw: what criteria do you have for tagging new release ? I see that last one was back in April.

[ljharb]

No criteria; mainly when I feel it's ready.