New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
July 5th "Shellcheck recommendations" patch broke profile set up #458
Comments
Not really related, why did you change it to the string substitution version? |
I've been trying to follow shellcheck's recommendations, but obviously I didn't understand the implications of this particular change. |
That said, this is in master, not a tagged release, so it shouldn't break anyone - nobody should be installing off of master except to test upcoming releases. |
The additional quotes are proper changes, but in the case of |
This doesn't fix the issue. |
Fixed in #460 |
:-) |
In install.sh, changing the printf lines from:
printf $SOURCE_STR
to
printf "%s" "$SOURCE_STR"
broke the profile appending code. With printf "%s", the "\n" characters in $SOURCE_STR are written verbatim rather than a written as new lines. E.G., it looks like this in my .bash_profile:
\nexport NVM_DIR="/home/vagrant/.nvm"\n[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm
You should revert that change.
Commit ID: e0537ce
PS: You should add a trailing newline to the insertion as well.
The text was updated successfully, but these errors were encountered: