Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions are unclear for most people (Discussion) #748

Closed
JonnyBurger opened this issue May 6, 2015 · 2 comments
Closed
Labels
installing nvm: profile detection Issues with nvm's own install script, related to figuring out the right profile file. needs followup We need some info or action from whoever filed this issue/PR.

Comments

@JonnyBurger
Copy link

Hello everyone!

I feel like the documentation should make it clearer that you need to run source ~/.nvm/nvm.sh after installing if you use zsh.
Many people are running the install script and are then wondering why they get a zsh: command not found: nvm error. In fact, over 10000 people had to consult Stackoverflow to get nvm running including myself, I'd imagine that there are even more people that are not using nvm at all because of this.

Do you agree that we should make it clearer?
If so, what changes should we make specifically? Let's discuss.

Thanks for the really awesome software.
Best,
Jonny

@ljharb ljharb added the installing nvm: profile detection Issues with nvm's own install script, related to figuring out the right profile file. label May 6, 2015
@ljharb
Copy link
Member

ljharb commented May 6, 2015

You don't, typically. It depends on the specific array of profile files that each user has on their system.

I'd love to fix it, but non-interactive profile detection is insanely complex. I'll certainly be happy to accept README PRs like #704, but I'd rather figure out a better way to properly do profile file detection.

Another solution is to modify all profile files, but that seems dangerous because, for example, I have my bashrc set up to be sourced by bash_profile - but perhaps we could get around that by checking for the existence of the nvm function and checking the version, to avoid double-sourcing.

@ljharb ljharb added the needs followup We need some info or action from whoever filed this issue/PR. label May 6, 2015
@JonnyBurger
Copy link
Author

I see. I was looking for the issue #704, but couldn't find it via search, because the wording was different. I'll continue the discussion there!
Thanks for the response.

nuriel added a commit to nuriel/nvm that referenced this issue Jan 10, 2016
reflect the need to optionally source nvm after curl based installation.
nvm-sh#704 nvm-sh#748 and http://stackoverflow.com/a/17707224/690866
connor11528 added a commit to connor11528/nvm that referenced this issue May 25, 2020
This is in response to a popular stack overflow answer that has helped people resolve the "command not found" hiccup: https://stackoverflow.com/a/17707224/2031033

Also mentioned here: nvm-sh#748
ljharb pushed a commit to connor11528/nvm that referenced this issue Jun 23, 2020
This is in response to a popular stack overflow answer that has helped people resolve the "command not found" hiccup: https://stackoverflow.com/a/17707224/2031033

Also mentioned here: nvm-sh#748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing nvm: profile detection Issues with nvm's own install script, related to figuring out the right profile file. needs followup We need some info or action from whoever filed this issue/PR.
Projects
None yet
Development

No branches or pull requests

2 participants