fix open string in line 784 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 7, 2017
| @@ -781,7 +781,7 @@ nvm_strip_iojs_prefix() { | |||
| if [ "${1-}" = "${NVM_IOJS_PREFIX}" ]; then | |||
| nvm_echo | |||
| else | |||
| nvm_echo "${1#"${NVM_IOJS_PREFIX}"-}" | |||
| nvm_echo "${1#${NVM_IOJS_PREFIX}-}" | |||
There was a problem hiding this comment.
vim is incorrect - these nested quotes are quite valid.
You can test this on the command line with:
export A='iojs-1.2.3"
export NVM_IOJS_PREFIX='iojs'
echo "${A#"${NVM_IOJS_PREFIX}"-}"and it will output "1.2.3"
There was a problem hiding this comment.
The nested quotes "${NVM_IOJS_PREFIX}" aren't necessary. And some editors will either show/highlight a syntax error or show treat the following as a big string, rather than valid bash (or sh) code.
with quotes
without quotes
There was a problem hiding this comment.
That sounds like a bug in some editors to me.
ljharb
approved these changes
Mar 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove extra pair of quotes that vim suggests as syntax error in line 784