[Refactor] nvm.sh minor refactor #1421
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterDaveHello
force-pushed
the
refactor-nvm.sh
branch
from
7f97066
to
d041b4e
Compare
ljharb
requested changes
Mar 14, 2017
nvm.sh
Outdated
| @@ -640,7 +640,6 @@ nvm_list_aliases() { | |||
| nvm_echo "${LTS_ALIAS}" | |||
| fi | |||
| done | |||
| return | |||
There was a problem hiding this comment.
This is done intentionally to avoid any previous commands' exit codes from leaking through.
nvm.sh
Outdated
| @@ -2121,7 +2120,6 @@ nvm_check_file_permissions() { | |||
| if [ "${ZSH_HAS_NONOMATCH_UNSET}" -eq 1 ] && nvm_has "setopt"; then | |||
| setopt nomatch | |||
| fi | |||
| return 0 | |||
PeterDaveHello
force-pushed
the
refactor-nvm.sh
branch
from
d041b4e
to
d8538da
Compare
ljharb
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.