[Fix] declare MANPATH if and only if it's not set #1430
Conversation
|
To confirm, did you file this in response to 186509b#commitcomment-21338872? |
|
That comment seem to copy my commit message and comment, not sure what should I do there? |
|
Don't worry about that comment :-) It sounds like we've got two separate issues - the fix for one creates the other. Can we find a way to fix both? |
|
@ljharb workaround: quite |
|
Isn't this patch fixed both? I though it fixed both. |
|
Oh, hmm. It might indeed; I thought it was a simple revert Let me test it locally to make sure. |
By manpath's man page in Ubuntu 16.04: > If $MANPATH is set, manpath will simply display its contents and issue > a warning. By fa22d71 for nvm-sh#1413, `nvm` now will declare the "MANPATH" variable, no matter if it's set or not, so in the situation that $MANPATH is set, you'll get the warning: > manpath: warning: $MANPATH set, ignoring /etc/manpath.config
PeterDaveHello
force-pushed
the
manpath-fix
branch
from
54637aa
to
b879628
Compare
|
@PeterDaveHello hmm, every master build since this was merged is erroring on 3 or 4 of the 4 "slow" tests, repeatedly. Any idea? https://travis-ci.org/creationix/nvm/builds/212626859 |
|
I'm not sure if it's related, unless b879628 passed here: https://travis-ci.org/creationix/nvm/builds/212504980 |
|
@ljharb it looks no problem by my side, confused 😕 |
|
Maybe it's Travis CI's problem, also be fine in this repo now: |
|
I had to rerun the builds many times before they would pass. I agree it doesn't seem related, but this PR is the first commit on master where the problem occurred. |
By manpath's man page in Ubuntu 16.04:
By fa22d71 for #1413,
nvmnow willdeclare the "MANPATH" variable, no matter if it's set or not, so in the
situation that $MANPATH is set, you'll get the warning: