[Docs] Update Installation section #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If we are not going to install nodejs or io.js from source, we may not need to have c++ compiler or libssl-dev package 2. the `build-essential` and `libssl-dev` packages should work on all the Debian and Ubuntu based GNU/Linux distros 3. Remove useless blank lines
ljharb
approved these changes
Mar 15, 2017
README.markdown
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| ## Installation | |||
|
|
|||
| First you'll need to make sure your system has a c++ compiler. For OS X, Xcode will work, for Ubuntu, the `build-essential` and `libssl-dev` packages work. | |||
| If you're going to install nodejs or io.js from its source code, you'll need to make sure your system has a c++ compiler. For OS X, Xcode will work, for Debian/Ubuntu based GNU/Linux, the `build-essential` and `libssl-dev` packages work. | |||
There was a problem hiding this comment.
We should specify here that "installing from its source code" is only necessary when there is not a prepackaged binary available for your system.
ljharb
requested changes
Mar 15, 2017
README.markdown
Outdated
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| ## Installation | |||
|
|
|||
| First you'll need to make sure your system has a c++ compiler. For OS X, Xcode will work, for Ubuntu, the `build-essential` and `libssl-dev` packages work. | |||
| If you're running a system without prepackaged binary available, which means you'll going to install nodejs or io.js from its source code, you need to make sure your system has a c++ compiler. For OS X, Xcode will work, for Debian/Ubuntu based GNU/Linux, the `build-essential` and `libssl-dev` packages work. | |||
PeterDaveHello
force-pushed
the
readme
branch
3 times, most recently
from
cca768b
to
5475f6b
Compare
ljharb
approved these changes
Mar 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not need to have c++ compiler or libssl-dev package
build-essentialandlibssl-devpackages should work on allthe Debian and Ubuntu based GNU/Linux distros