Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update CONTRIBUTING.md #1448

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Conversation

PeterDaveHello
Copy link
Collaborator

The origin one looks like it's for PR only, let's add something about the issue?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM pending one wording comment

CONTRIBUTING.md Outdated

However, before submitting, please review the following:

For bug reports:
- Please make sure the bug is reproducible, and give us the steps to reproduce it, so that we can dig into the problem.
- Please give us the info about your environments as detail as possible, so that we can confirm the problem easier.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please give us as much detail as possible about your environment, so we can more easily confirm the problem"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@ljharb ljharb merged commit 20a40dd into nvm-sh:master Mar 22, 2017
@PeterDaveHello PeterDaveHello deleted the CONTRIBUTING.md branch March 23, 2017 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants