Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue template update #1452

Merged
merged 3 commits into from
Mar 23, 2017
Merged

Conversation

PeterDaveHello
Copy link
Collaborator

This could make sure the situation is more like what it really is, and also make the output smaller.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you can confirm that when there are SSL certificate errors, -I will include that information (which seems likely)

@PeterDaveHello
Copy link
Collaborator Author

sorry that I think I didn't follow the situation up here, do you mean the last test failed?

@ljharb
Copy link
Member

ljharb commented Mar 23, 2017

@PeterDaveHello no, i mean, the sole purpose of having that curl command in the readme is to expose when a user's SSL certificate authorities are out of date, thus making them unable to connect to nodejs.org - so I'm asking if -I will include that information in that failure case?

@PeterDaveHello
Copy link
Collaborator Author

@ljharb you'll get something like this if the cert is invalid:

curl: (60) server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

curl will tell what the problem is there, no problem at all

@ljharb ljharb merged commit 6ef2be8 into nvm-sh:master Mar 23, 2017
@PeterDaveHello PeterDaveHello deleted the issue-template-update branch March 23, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants