Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] curl should fail if something wrong, fix #1556 #1557

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

from curl man page:

 -f, --fail
              (HTTP) Fail silently (no output at all) on server errors. This is mostly done to better enable scripts  etc  to  better  deal
              with failed attempts. In normal cases when an HTTP server fails to deliver a document, it returns an HTML document stating so
              (which often also describes why and more). This flag will prevent curl from outputting that and return error 22.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm which versions of curl have this support?

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Jun 14, 2017

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good; can you provide the output that this change causes from the command in #1556?

@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Jun 14, 2017
@PeterDaveHello
Copy link
Collaborator Author

curl: (22) The requested URL returned error: 404 Not Found

@ljharb ljharb merged commit 11370fe into nvm-sh:master Jun 14, 2017
@PeterDaveHello PeterDaveHello deleted the curl-fix branch June 14, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants