New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also unset NVM_RC_VERSION when unloading #1607

Merged

ljharb merged 1 commit into nvm-sh:master from zeorin:unload-fix

Sep 8, 2017

Contributor

zeorin commented Sep 7, 2017

nvm_unload was unsetting RC_VERSION instead of NVM_RC_VERSION. Am I correct in thinking this was a typo?


          [Fix] unset NVM_RC_VERSION when unloading

44ab611

ljharb approved these changes

View reviewed changes

Member

ljharb left a comment

Thanks! Looks like this was introduced in 744507b, and so it's never been correct.

ljharb merged commit 44ab611 into nvm-sh:master

ljharb added the bugs label

zeorin deleted the unload-fix branch

September 9, 2017 09:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment