Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the manual ShellCheck install proecss on Travis CI #1619

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

PeterDaveHello
Copy link
Collaborator

Travis CI now provides the latest ShellCheck and I believe that we don't need to maintain our own installation any more so that we can save both time and resources!

@ljharb
Copy link
Member

ljharb commented Sep 27, 2017

This test run doesn't actually demonstrate that we don't have to install shellcheck, because we cache the cabal directory. I think we'd have to remove that cache to verify that in fact it was already installed.

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Sep 27, 2017
@PeterDaveHello
Copy link
Collaborator Author

I think the update of $PATH demonstrates that?

@ljharb
Copy link
Member

ljharb commented Sep 28, 2017

@PeterDaveHello
Copy link
Collaborator Author

Oh ... my fault, updated!

@ljharb ljharb merged commit 707d268 into nvm-sh:master Sep 28, 2017
@PeterDaveHello PeterDaveHello deleted the refactor-travis-config branch September 28, 2017 17:59
PeterDaveHello added a commit to PeterDaveHello/nvm that referenced this pull request Oct 21, 2017
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
…nfig

Remove the manual ShellCheck install proecss on Travis CI
edwmurph pushed a commit to edwmurph/nvm that referenced this pull request Apr 9, 2018
AGhost-7 pushed a commit to AGhost-7/nvm that referenced this pull request Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants