Spelling #1756
Merged
Spelling #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 6, 2018
| @@ -13,7 +13,7 @@ die () { echo "$@" ; exit 1; } | |||
| nvm use --delete-prefix v0.2.3 || die "Failed to activate v0.2.3" | |||
| [ `expr "$PATH" : ".*v0.2.3/.*/bin.*"` != 0 ] || die "PATH not set up properly" | |||
| [ `expr "$NODE_PATH" : ".*v0.2.3/.*/lib/node_modules.*"` = 0 ] || die "NODE_PATH should not contain (npm root -g)" | |||
| # ^ note: NODE_PATH should not contain `npm root -g` since globals should not be requireable | |||
There was a problem hiding this comment.
This is correct as-is, since it’s dealing with the “require” function
|
@ljharb: dropped |
ljharb
approved these changes
Mar 7, 2018
|
@PeterDaveHello there's no order that PRs generally need to be merged in; submitting it sooner doesn't guarantee it will be merged first. I'll always handle the rebase if it's needed. |
|
Okay, just want to prevent rebasings and conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by https://github.com/jsoref/spelling
f; to maintain your repo, please considerfchurn