Update ISSUE_TEMPLATE.md #2107
Merged
Update ISSUE_TEMPLATE.md #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the need to indent terminal output by using headings instead of a list. Simplify formulation of steps
ljharb
reviewed
Oct 8, 2019
.github/ISSUE_TEMPLATE.md
Outdated
| - If you are having installation issues, or getting "N/A", what does `curl -I --compressed -v https://nodejs.org/dist/` print out? | ||
| <details> | ||
| <!-- do not delete the following blank line --> | ||
| #### What does `curl -I --compressed -v https://nodejs.org/dist/` print out? |
There was a problem hiding this comment.
by rewording this, I'm worried that I'll get a bunch of useless curl output, more often. Why do you think this ordering is better?
There was a problem hiding this comment.
My reasoning was that it would provide a simpler to read issue. But I get your worry that it would be easy to miss the comment below.
In my case, I thought I had to execute the script, until I read the comment stating if this section does not apply .... Somehow I failed to read the If you are having installation issues, or getting "N/A", ... part, and skipped right to the terminal command.
Let me remove this, it's bikeshedding anyhow.
ljharb
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some tweaks to your PR template: