Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ISSUE_TEMPLATE.md #2107

Merged
merged 1 commit into from Oct 12, 2019

Conversation

@guidobouman
Copy link
Contributor

commented Oct 8, 2019

I made some tweaks to your PR template:

  • Remove the need to indent terminal output by using headings instead of a list.
  • Simplify formulation of steps
Remove the need to indent terminal output by using headings instead of a list.
Simplify formulation of steps
- If you are having installation issues, or getting "N/A", what does `curl -I --compressed -v https://nodejs.org/dist/` print out?
<details>
<!-- do not delete the following blank line -->
#### What does `curl -I --compressed -v https://nodejs.org/dist/` print out?

This comment has been minimized.

Copy link
@ljharb

ljharb Oct 8, 2019

Member

by rewording this, I'm worried that I'll get a bunch of useless curl output, more often. Why do you think this ordering is better?

This comment has been minimized.

Copy link
@guidobouman

guidobouman Oct 9, 2019

Author Contributor

My reasoning was that it would provide a simpler to read issue. But I get your worry that it would be easy to miss the comment below.

In my case, I thought I had to execute the script, until I read the comment stating if this section does not apply .... Somehow I failed to read the If you are having installation issues, or getting "N/A", ... part, and skipped right to the terminal command.

Let me remove this, it's bikeshedding anyhow.

@ljharb
ljharb approved these changes Oct 12, 2019
@ljharb ljharb merged commit 0a4e6f2 into nvm-sh:master Oct 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guidobouman guidobouman deleted the guidobouman:patch-1 branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.