Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] Add documentation for LTS updates which reinstall existing packages #2271

Merged
merged 1 commit into from Aug 1, 2020
Merged

[readme] Add documentation for LTS updates which reinstall existing packages #2271

merged 1 commit into from Aug 1, 2020

Conversation

saikatdas0790
Copy link
Contributor

Added an example for LTS updates that also reinstall the existing packages.
This is useful for individuals who run the latest LTS version along with global packages and need to update when the LTS version gets bumped

…ackages

Added an example for LTS updates that also reinstall the existing packages.
This is useful for individuals who run the latest LTS version along with global packages and need to update when the LTS version gets bumped
README.md Outdated Show resolved Hide resolved
@ljharb ljharb added informational installing node Issues with installing node/io.js versions. labels Jul 29, 2020
@saikatdas0790
Copy link
Contributor Author

@ljharb I'm not sure why the checks failed. I'm just adding a line to the README.md.

Thoughts?

@ljharb
Copy link
Member

ljharb commented Aug 1, 2020

@saikatdas0790 in this case it's because the branch needs to be rebased (not "updated" with a merge commit). I can take care of it for you.

@saikatdas0790
Copy link
Contributor Author

Sure. Thank you 😊

@ljharb ljharb changed the title Add documentation for LTS updates which reinstall existing packages [readme] Add documentation for LTS updates which reinstall existing packages Aug 1, 2020
@ljharb ljharb merged commit 18c6f98 into nvm-sh:master Aug 1, 2020
@saikatdas0790 saikatdas0790 deleted the patch-1 branch August 5, 2020 05:55
@saikatdas0790
Copy link
Contributor Author

@ljharb So, I just tested this and turns out using --lts doesn't work

But using 'lts/*' does work

Here are screenshots:

--lts
image

'lts/*'
image

@ljharb
Copy link
Member

ljharb commented Aug 7, 2020

Well that’s unfortunate :-) i assumed your example was based on you actually using that command.

We’ll need to either revert this, tweak it, or fix the bug.

@saikatdas0790
Copy link
Contributor Author

saikatdas0790 commented Aug 10, 2020

@ljharb My example was based on the "lts/*" command that I'd used. Based on your comments over here, I assumed the "--lts" was a drop in replacement. Apologies but I hadn't tested that explicitly :(
image

I will add another pull request to change the readme to use "lts/*"? Also, apologies for the late replies. I've got the Github mobile app now that should let me know in case I've received a mention

Also thank you for being patient with me. I'm relatively new to the nuances of the Github Pull Request workflow

@ljharb
Copy link
Member

ljharb commented Aug 10, 2020

A new PR to fix the docs sounds great; if you felt like filing (or locating and pinging) an issue about the actual command not working that'd be great too.

@saikatdas0790
Copy link
Contributor Author

saikatdas0790 commented Aug 10, 2020

I will create a new PR and the new issue stating the actual command not working.

I mostly have experience with front-end JavaScript and a bit of NodeJS foo. If someone is willing to provide inputs on how to pinpoint and fix the issue, I'd be willing to put in time to fix the actual command not working as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
informational installing node Issues with installing node/io.js versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants