Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated sudo: option in TravisCI config #2307

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

PeterDaveHello
Copy link
Collaborator

That config was deprecated for a while, reference:

@ljharb
Copy link
Member

ljharb commented Sep 21, 2020

What that specifically says is:

if you use a specific build environment group and do not specify sudo: required, it’s possible you’ll see slight variations in your build environment as projects are migrating.

In other words, sudo: false was deprecated, not sudo: required - without the explicit config value, travis applies a heuristic to determine if sudo is available. I'm not sure the tests can pass without it.

@ljharb ljharb added the testing Stuff related to testing nvm itself. label Sep 21, 2020
@PeterDaveHello
Copy link
Collaborator Author

Looks like the quote was just part of the "Migration Timeline", but the migration was finished already, there shouldn't be any difference about specified sudo: or not?,

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gotten confirmation from travis that sudo: required is indeed a noop, so this can land. Thanks!

@ljharb ljharb merged commit 4436638 into nvm-sh:master Oct 8, 2020
@PeterDaveHello PeterDaveHello deleted the UpdateTravisConfig branch October 10, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Stuff related to testing nvm itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants