Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: Updated README.md to include homebrew unsecure dirs warning #2388

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[Docs]: Updated README.md to include homebrew unsecure dirs warning #2388

merged 1 commit into from
Dec 29, 2020

Conversation

hjoshi123
Copy link
Contributor

@hjoshi123 hjoshi123 commented Dec 22, 2020 •
edited
Loading

Updated warning for insecure directories while homebrew is installed. Raising PR for #2361

ljharb
ljharb requested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make it clear that this is a problem specific to Mac, zsh, and having homebrew installed.

README.md Outdated Show resolved Hide resolved
@hjoshi123
Copy link
Contributor Author

@ljharb Let me know if some changes are required.. I have rebased the branch..

@ljharb ljharb merged commit 6982dee into nvm-sh:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational OS: Mac OS shell: zsh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hjoshi123 @ljharb