Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade ubuntu from 16.04 to xenial-20210114 #2537

Closed
wants to merge 1 commit into from

Conversation

snyk-bot
Copy link

Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Changes included in this PR

  • Dockerfile

We recommend upgrading to ubuntu:xenial-20210114, as this image has only 47 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.

Some of the most important vulnerabilities in your base image include:

Severity Priority Score / 1000 Issue Exploit Maturity
low severity 321 Improper Check for Dropped Privileges
SNYK-UBUNTU1604-BASH-542609
Mature
medium severity 300 Information Exposure
SNYK-UBUNTU1604-SYSTEMD-346739
No Known Exploit
medium severity 300 Information Exposure
SNYK-UBUNTU1604-SYSTEMD-346739
No Known Exploit
medium severity 300 Information Exposure
SNYK-UBUNTU1604-SYSTEMD-346739
No Known Exploit
medium severity 300 Information Exposure
SNYK-UBUNTU1604-SYSTEMD-346739
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

@ljharb
Copy link
Member

ljharb commented Jul 15, 2021

cc @PeterDaveHello

Dockerfile Outdated
@@ -6,7 +6,7 @@
# Please note that it'll use about 1.2 GB disk space and about 15 minutes to
# build this image, it depends on your hardware.

FROM ubuntu:16.04
FROM ubuntu:xenial-20210114
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I really prefer not to specify such precise version tag as it'll only make it obsolete more frequently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would you suggest?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to stay the way that we just specify the LTS version of it ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here comes #2540, as I said, it'll only make it obsolete more frequently.

#2537 is using xenial-20210114 and #2540 is using xenial-20210416, it's more like keeping using the latest snapshot tag...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What tag can we use that would avoid this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what "if the master branch's tag auto-updated" means? When xenial-20210114 was tagged, I believe xenial and 16.04 will also be updated, just not specified to be a certain snapshot like xenial-20210114, but that'll be good enough for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. then that implies that snyk shouldn't be warning on this at all. let me ask them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks 👋

I shared with the team internally at Snyk.
Looks like there's some planned work for this on Q4 although I'm not sure to which detail/extent. Might be to update/rebase a PR, or to manage the noise level down.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @lirantal !

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing new on my end yet, but feel free to reach out with a ping here or https://twitter.com/liran_tal if you wanted to chime in on anything.

@ljharb ljharb marked this pull request as draft September 29, 2021 05:29
@ljharb ljharb force-pushed the snyk-fix-9965d6401b654027444efb1538b14d61 branch from e84c91b to 58f6575 Compare October 8, 2022 16:24
@ljharb ljharb closed this Oct 8, 2022
@ljharb ljharb deleted the snyk-fix-9965d6401b654027444efb1538b14d61 branch October 8, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants