Fix which to use conventional direct path to program #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -965,7 +965,7 @@ nvm() { | |||
|
|
|||
| if [ "_$VERSION" = '_system' ]; then | |||
| if nvm_has_system_node >/dev/null 2>&1; then | |||
| echo $(nvm use system && echo dirname $(which node)) | |||
| echo $(nvm deactivate > /dev/null 2>&1 && echo $(which node)) | |||
There was a problem hiding this comment.
I'd prefer nvm use system >/dev/null 2>&1 rather than deactivate here, but suppressing stdout is a good change.
Also, do you need the echo $(which node) or can it just be which node?
|
Also, can you rebase this on top of latest master, so there's no merge commits dirtying the log? |
|
Awesome, thanks! |
ljharb
added a commit
that referenced
this pull request
Dec 19, 2014
Fix `nvm which` to use conventional direct path to program, like system `which`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes
nvm which systemso it doesn't echo anything extra.