Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

VaSelect - value must be string #69

Closed
rejifald opened this issue Feb 17, 2019 · 1 comment
Closed

VaSelect - value must be string #69

rejifald opened this issue Feb 17, 2019 · 1 comment
Assignees
@nvms
Labels
enhancement New feature or request

Comments

@rejifald
Copy link
Contributor

Hi.
I found this

vue-atlas/src/Select/VaOption.vue

Line 16 in cd81da1

type: String

I believe that value can be not only string, but any other JS type. Including object.
I don't see reason why it should be restricted. Especially if label prop exists.
So i may want to have value as Object, or as Number.
It's real problem that i have now. I want to have value as Number.
WDYT ?
nvms added a commit that referenced this issue Feb 17, 2019
@nvms
[patch] #69
91a4ee6
@nvms nvms self-assigned this Feb 17, 2019
@nvms nvms added the enhancement New feature or request label Feb 17, 2019
@nvms
Copy link
Owner

nvms commented Feb 17, 2019

this is a good idea. added in 91a4ee6. will update documentation sometime today

@nvms nvms closed this as completed Feb 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nvms nvms

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nvms @rejifald