Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move CNDC to be an intermediate core parameter #46

Open
apswong opened this issue Jun 27, 2022 · 3 comments
Open

move CNDC to be an intermediate core parameter #46

apswong opened this issue Jun 27, 2022 · 3 comments

Comments

@apswong
Copy link

apswong commented Jun 27, 2022

I would like to propose moving CNDC to be an "intermediate core" parameter. This proposal is supported by @cabanesc and @coatanoan.

CNDC is by nature an intermediate parameter, being an input to compute salinity. Most floats do not return this parameter; only some floats from the early days of Argo, and some experimental floats, do so. For the floats that do return CNDC, delayed-mode operators need to do a superficial step to fill CNDC_ADJUSTED with adjustments derived from salinity. This is an awkward step, as some salinity adjustments, such as the cell thermal lag correction, should not be applied to CNDC.

In the past, we were not able to designate parameters as "intermediate core". But now we can. Being an intermediate parameter means there is no need to include CNDC_ADJUSTED, CNDC_ADJUSTED_QC and CNDC_ADJUSTED_ERROR in the Argo data files.

@catsch
Copy link

catsch commented Jun 29, 2022

It makes sense. @apswong, tell me when I have green light to update the parameters list

@tcarval tcarval transferred this issue from nvs-vocabs/R03 Dec 9, 2022
@catsch
Copy link

catsch commented Dec 9, 2022 via email

@tcarval
Copy link
Contributor

tcarval commented Jan 28, 2023

The parameters list is now published on ADMT web site : http://www.argodatamgt.org/Data-Mgt-Team/News/Argo-physical-parameters-list-updated7
Next steps :

  • update the file format checker to manage CNDC as intermediate core parameter. No more adjustment on CNDC parameter : CNDC_ADJUSTED, CNDC_ADJUSTED_ERROR (CNDC_*) should not be reported in Argo NetCDF files.
  • update the DACs decoders to remove CNDC_* from real-time adjusted files
  • Should we (?) update the delayed mode data processing chains to remove CNDC_* from delayed mode files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
AVTT issues management
  
AVTT approval
Development

No branches or pull requests

3 participants