Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table 27: OCR504_ICSW sensor, remove satlantic reference #11

Closed
tcarval opened this issue Dec 9, 2021 · 10 comments
Closed

table 27: OCR504_ICSW sensor, remove satlantic reference #11

tcarval opened this issue Dec 9, 2021 · 10 comments

Comments

@tcarval
Copy link

tcarval commented Dec 9, 2021

An OCR multispectral radiometer SENSOR_MODEL is currently "SATLANTIC_OCR504_ICSW" in reference table 27.
SeaBird Electronics acquired both Wetlabs and Satlantic years back, so Seabird Scientific (SBS) encompasses all three sensor makers.

Proposal: add a new sensor model "OCR504_ICSW" with no mention of the sensor maker.

Status: approved, tables 26 and 27 updated on 2021-27-12

Comment: depending on date of purchase of the sensor (before or after SBS acquisition) use these terms:
Before SATLANTIC acquisition by SBS:

  • SATLANTIC_OCR504_R10W
  • SATLANTIC_OCR507_ICSW
  • SATLANTIC_OCR507_R10W
  • SATLANTIC_OCR507_ICSWR10W
  • SATLANTIC_PAR

After SATLANTIC acquisition by SBS:

  • OCR504_R10W
  • OCR507_ICSW
  • OCR507_R10W
  • OCR507_ICSWR10W
  • PAR
@tcarval
Copy link
Author

tcarval commented Dec 9, 2021

Claudia's message 29/11/2021
That sounds like the way to go about this.
During the transition, the GDAC format checker
could issue a warning instead of a rejection for
files using the old way.

Also:

  1. we may need some flexibility with respect to
    the 504. Right now, I see 504 and 507 in the
    reference table. Not sure if there will be other
    numbers in the future (i,e, sensors that use a
    number of channels that's neither 4 nor 7).
  2. there are more than two lines that need updating
    (_R10W, _ICSW, _ICSWR10W)
  3. what should be done about SATLANTIC_PAR?
    Maybe that can be just "PAR"?

@tcarval
Copy link
Author

tcarval commented Dec 10, 2021

The floats fitted with OCR504_ICSW are currently rejected on GDAC.
File format checker report:
Dac: 'aoml'
File: 'nc_2021.10.29_18.15.tar.gz:::5906446_meta.nc'
Type: 'META-DATA'
Version: '3.1'
PI Name: 'STEPHEN RISER'
Current Time (UCT): Fri Oct 29 22:45:44 2021
Reason:
SENSOR_MODEL[4]: 'OCR504_ICSW' Status: Invalid
SENSOR_MODEL[5]: 'OCR504_ICSW' Status: Invalid
SENSOR_MODEL[6]: 'OCR504_ICSW' Status: Invalid
SENSOR_MODEL[7]: 'OCR504_ICSW' Status: Invalid

@tcarval tcarval changed the title table 25: OCR504_ICSW sensor, remove satlantic reference table 27: OCR504_ICSW sensor, remove satlantic reference Dec 10, 2021
@vpaba vpaba self-assigned this Dec 14, 2021
@vpaba
Copy link
Contributor

vpaba commented Dec 14, 2021

@tcarval, would it be ok for me to move this issue to https://github.com/nvs-vocabs/R27/issues?

@tcarval
Copy link
Author

tcarval commented Dec 14, 2021

@tcarval, would it be ok for me to move this issue to https://github.com/nvs-vocabs/R27/issues?

Yes please

@vpaba vpaba transferred this issue from nvs-vocabs/ArgoVocabs Dec 14, 2021
@apswong
Copy link

apswong commented Dec 16, 2021

Hello, @tcarval @vpaba
I thought the agreement at the ADMT was that both "SATLANTIC_OCR504_ICSW" and "OCR504_ICSW" would exist in Ref Table 27, so that DACs can use either entry, depending on date of purchase of the sensor (before or after SBS acquisition). In other words, "SATLANTIC_OCR504_ICSW" (and other "SATLANTIC_***" sensor models) should not be deprecated in Ref Table 27.

@vpaba
Copy link
Contributor

vpaba commented Dec 16, 2021

@apswong this was my understanding too.

@tcarval
Copy link
Author

tcarval commented Dec 16, 2021

Hello, @vpaba @apswong
Yes, this is correct, I just updated the first message of this issue, "OCR504_ICSW" is now valid, the current SATLANTIC_* terms remain valid and should not be "deprecated" .

@tcarval
Copy link
Author

tcarval commented Dec 25, 2021

Hello Claudia,
Here are corrections needed on your metadata files, taking into account the additions in table 26 and 27.
The file format checker should be updated within a few days.

grep -i <error> $WRK/out/*
Replace "SBE" with "Sea-Bird Scientific"
5906320_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[4]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906320_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[5]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906320_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906320_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[7]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906446_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[4]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906446_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[5]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906446_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'OCR504_ICSW'/'SBE'
5906446_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[7]: Inconsistent: 'OCR504_ICSW'/'SBE'

Replace "MBARI" with "SBE"
5906448_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906449_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906450_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906468_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906469_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906470_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906471_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906473_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906474_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'
5906476_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[6]: Inconsistent: 'SEAFET'/'MBARI'

Existing KELLER model : "KELLER_PA8"
5906418_meta.nc.filecheck: SENSOR_MODEL[1]: 'unknown' Status: Invalid

Replace "RBR" with "DRUCK"
5906457_meta.nc.filecheck: SENSOR_MODEL/SENSOR_MAKER[3]: Inconsistent: 'DRUCK_2900PSIA'/'RBR'

@tcarval
Copy link
Author

tcarval commented Dec 25, 2021

Hello @vpaba , can you add Claudia and Mark in the nvs-vocab members ?

@tcarval
Copy link
Author

tcarval commented Dec 28, 2021

Message from Claudia
Hi Thierry,
I looked at the format checker comparison.
There, OCR504_ICSW is listed with "Sea-Bird Scientific" instead of SBE,
but NVS seems to say it should be SBE.
Please review this and let me know what it should be (seems to me one or
the other needs to change).

Answer from Thierry
« Sea-Bird Scientific » is the name that is now communicated on Seabird web site (https://www.seabird.com).
The consensus in ADMT-22 was to use the brands and models as communicated by the companies.
So “SBE” remains the name for Seabird sensors existing entries.
New sensor entries should use “Sea-Bird Scientific”.
That is conservative (we do not change existing sensor entries), still evolutive (new sensor entries use the most recent brand and model).

@vpaba vpaba added this to To do in AVTT issues management via automation Dec 7, 2022
@tcarval tcarval closed this as completed Dec 8, 2022
AVTT issues management automation moved this from To do to Done Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants