Skip to content

Commit

Permalink
ci: predictable server builds and port option (#312)
Browse files Browse the repository at this point in the history
Implement the ability to create predictable server builds so that the
workflows can validate that it's been updated as needed.

This adds the  workflow lint which validates that everything has been
built and lint fixes applied.

This switches running the server to use -jar to reduce complexity now
the manifest is correctly created.

Add missing cli jars not needed for source runs, causing them to be
missed in previous commit.

Moved scripts into their own folder to keep the root directory cleaner.

This includes a lint:fix and build changes, unrelated to this as they
hadn't been run in the past.

Removed try catch in server runCodeNarc as it was resulting in
exceptions being logged twice.
  • Loading branch information
stevenh committed Oct 26, 2023
1 parent 8f2c9d1 commit 24f6edd
Show file tree
Hide file tree
Showing 20 changed files with 2,072 additions and 522 deletions.
148 changes: 76 additions & 72 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,75 +4,15 @@
"**/vscode-extension/**",
"**/.git/**",
".vscode",
"**/*.jar"
"**/*.jar",
"**/MANIFEST.MF",
"lib/example/**"
],
"language": "en",
"version": "0.1",
"version": "0.2",
"words": [
"Affero",
"Autofixable",
"Behl",
"Behl\u00fcl",
"Blablabla",
"CLASSNAME",
"CLASSPATH",
"CODENARC",
"COPYPASTE",
"Charsets",
"Cloneable",
"Codacy",
"Codenarc",
"Commandline",
"Creds",
"ECONNREFUSED",
"ENTRYPOINT",
"ETIMEOUT",
"FILEIO",
"Finalizers",
"Fixrules",
"Gorm",
"Hashtable",
"Inet",
"Instanceof",
"Intall",
"Javadoc",
"Jdbc",
"Jenkinsfile",
"Jenkinsfiles",
"Kopka",
"Loopback",
"MYOTHERVAR",
"MYVAR",
"Metadatas",
"Microbundle",
"Misordered",
"NEWLINECLOSINGBRACE",
"Nuxt",
"OPTIONNAME",
"Objs",
"PARAMNAME",
"PROSELINT",
"Pawel",
"Println",
"Ruleset",
"Rulesets",
"SARIF",
"SEMGREP",
"Sarif",
"Serv",
"Servlet",
"Slctn",
"Slurper",
"Sublicensing",
"TRIVY",
"Tablesort",
"U\u00e7ar",
"VARNAME",
"Vuillamy",
"WIPO",
"WORKDIR",
"Whitespaces",
"aestasit",
"Affero",
"agorapulse",
"analyse",
"anymatch",
Expand All @@ -81,37 +21,56 @@
"arity",
"arrayish",
"atlassian",
"Autofixable",
"autofixing",
"beakerx",
"behaviour",
"Behl",
"Behlül",
"blablabla",
"Blablabla",
"btime",
"callsites",
"camelcase",
"cdci",
"chardet",
"Charsets",
"chownr",
"circleci",
"CLASSNAME",
"CLASSPATH",
"clientid",
"cliui",
"Cloneable",
"Codacy",
"codecov",
"codehaus",
"codenarc",
"Codenarc",
"CODENARC",
"codenarcargs",
"Commandline",
"commondir",
"COPYPASTE",
"Creds",
"cvfm",
"decamelize",
"dfsg",
"docwhat",
"Dorg",
"dotenv",
"doublons",
"ecnfo",
"ECONNREFUSED",
"entrypoint",
"ENTRYPOINT",
"eslintcache",
"espree",
"esquery",
"esrecurse",
"estraverse",
"esutils",
"ETIMEOUT",
"excptn",
"extglob",
"failon",
Expand All @@ -120,22 +79,29 @@
"failonwarning",
"favicon",
"filechooser",
"FILEIO",
"fileoverview",
"fileset",
"finalise",
"Finalizers",
"fixrules",
"Fixrules",
"flattendeep",
"fontawesome",
"Fresources",
"fromentries",
"fsevents",
"Ftest",
"fullwidth",
"gaelyk",
"gaiden",
"gbench",
"gensync",
"getenv",
"getownpropertydescriptors",
"gitattributes",
"gmetrics",
"Gorm",
"gpars",
"gperfutils",
"gprof",
Expand All @@ -153,21 +119,30 @@
"grooylintrc",
"hadolint",
"hasha",
"Hashtable",
"hostedtoolcache",
"httpbuilder",
"httpserver",
"ignorepattern",
"imurmurhash",
"Inet",
"ìnfo",
"infrastructor",
"Instanceof",
"Intall",
"isarray",
"isexe",
"Javadoc",
"javaexecutable",
"javaoptions",
"javascripts",
"javax",
"jdbc",
"Jdbc",
"jdeploy",
"jenkinsfile",
"Jenkinsfile",
"Jenkinsfiles",
"jenkinsjobdsl",
"jenkinspipeline",
"jenkinssharedlib",
Expand All @@ -182,22 +157,31 @@
"katalon",
"killserver",
"kisswebframework",
"Kopka",
"lcov",
"lelama",
"lelamanul",
"lerna",
"levn",
"lintagainafterfix",
"loglevel",
"Loopback",
"markdownlint",
"materialx",
"megalinter",
"Metadatas",
"Microbundle",
"micronaut",
"microservice",
"minipass",
"minizlib",
"Misordered",
"mkdocs",
"modelcatalogue",
"mygroovyfile",
"MYOTHERVAR",
"MYVAR",
"NEWLINECLOSINGBRACE",
"nextflow",
"njre",
"nolintafter",
Expand All @@ -206,13 +190,18 @@
"notif",
"notkept",
"nuxt",
"Nuxt",
"nvuillam",
"Objs",
"occurrences",
"openjdk",
"optionator",
"OPTIONNAME",
"optns",
"orgs",
"overridden",
"PARAMNAME",
"Pawel",
"pawelkopka",
"pckg",
"pdxc",
Expand All @@ -221,23 +210,35 @@
"pids",
"pify",
"preload",
"Println",
"processinfo",
"promisified",
"PROSELINT",
"pymdownx",
"ratpack",
"readdirp",
"regexpp",
"restassured",
"returnrules",
"ruleset",
"Ruleset",
"rulesetfiles",
"rulesets",
"Rulesets",
"rulesetsoverridetype",
"sarif",
"Sarif",
"SARIF",
"SEMGREP",
"Serv",
"serverhost",
"serverport",
"Servlet",
"setalias",
"sfdx",
"simplelogger",
"Slctn",
"Slurper",
"soapui",
"socio",
"sourcefilepath",
Expand All @@ -251,17 +252,21 @@
"sshoogr",
"stehno",
"stylelint",
"Sublicensing",
"superlite",
"sysgears",
"Tablesort",
"tmptest",
"trimend",
"trimleft",
"trimright",
"trimstart",
"TRIVY",
"tsbuildinfo",
"twemoji",
"twhateverelse",
"typedarray",
"Uçar",
"ufeff",
"uncommented",
"universalify",
Expand All @@ -270,22 +275,21 @@
"updt",
"uuidv",
"uuuurf",
"VARNAME",
"vertx",
"vuepress",
"Vuillamy",
"warhod",
"wesh",
"whateverelse",
"Whitespaces",
"WIPO",
"WORKDIR",
"wrappy",
"wscript",
"yallist",
"yessss",
"zalgo",
"zpars",
"\u00ecnfo",
"mkdocs",
"Ftest",
"Fresources",
"simplelogger",
"Dorg"
"zpars"
]
}
42 changes: 42 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Update check

on:
push:
tags:
- v*
branches:
- main
pull_request:

permissions:
contents: read

jobs:
go:
name: Check for changes
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Install node
uses: actions/setup-node@v3
with:
node-version: 18

- name: Install groovy
uses: sdkman/sdkman-action@b1f9b696c79148b66d3d3a06f7ea801820318d0f
with:
candidate: groovy
version: 3.0.9

- name: Install dependencies and link
run: |
npm ci
npm link
- name: Validate no changes
run: |
npm run dev:pre-commit
git --no-pager diff
[[ 0 -eq $(git status --porcelain | wc -l) ]]
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ lib/com/


tmp/
tmptest/

local-storage.json

Expand All @@ -124,4 +125,4 @@ site/

report/
megalinter-reports/
github_conf/
github_conf/
4 changes: 0 additions & 4 deletions MANIFEST.txt

This file was deleted.

Loading

0 comments on commit 24f6edd

Please sign in to comment.