Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting + rules #20

Merged
merged 4 commits into from Apr 6, 2020
Merged

Fix formatting + rules #20

merged 4 commits into from Apr 6, 2020

Conversation

nvuillam
Copy link
Owner

@nvuillam nvuillam commented Apr 5, 2020

  • When formatting, always run some custom npm-groovy-lint fix rules not corresponding to CodeNarc violations
  • Return CodeNarc and Groovy versions when --version options is called
  • Fixes
    • Lost indentation when applying some fix rules
  • Updated fix rules:
    • IndentationClosingBraces
    • IndentationComments
    • SpaceAfterCatch
    • SpaceAfterIf
  • New fix rules:
    • ClassEndsWithBlankLine
    • ClassStartsWithNewLine
    • SpaceAfterFor
    • SpaceAfterSwitch

- When formatting, always run some custom npm-groovy-lint fix rules not corresponding to CodeNarc violations
- Updated fix rules:
  - IndentationClosingBraces
  - IndentationComments
- New fix rules:
  - ClassEndsWithBlankLine
@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #20 into master will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   92.81%   93.09%   +0.28%     
==========================================
  Files          43       47       +4     
  Lines        1224     1274      +50     
==========================================
+ Hits         1136     1186      +50     
  Misses         88       88              
Impacted Files Coverage Δ
src/codenarc-factory.js 97.10% <100.00%> (+0.03%) ⬆️
src/config.js 77.22% <100.00%> (+0.22%) ⬆️
src/groovy-lint-fix.js 99.27% <100.00%> (+0.05%) ⬆️
src/groovy-lint-rules.js 95.45% <100.00%> (+0.45%) ⬆️
src/groovy-lint.js 96.31% <100.00%> (+0.20%) ⬆️
src/rules/ClassEndsWithBlankLine.js 100.00% <100.00%> (ø)
src/rules/ClassStartsWithBlankLine.js 100.00% <100.00%> (ø)
src/rules/IndentationClosingBraces.js 100.00% <100.00%> (ø)
src/rules/IndentationComments.js 100.00% <100.00%> (ø)
src/rules/SpaceAfterCatch.js 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da605d2...ff189b7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants