chore: update node to 18 lts #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the node 18 lts so we're on a supported version.
Enable debug on all test workflows so we can understand any failures.
Reduce the amount of output in the log when running in debug.
|
@stevenh can it be merged ? :) Please remove the "draft" status of the PRs you consider ready ;) (i think this one is ^^ ) |
Add slf4j logging to CodeNarcServer so that we can control the log level.
nvuillam
reviewed
Oct 24, 2023
| @@ -32,13 +32,21 @@ import org.apache.tools.ant.types.Commandline | |||
| // CodeNarc main class | |||
| import org.codenarc.CodeNarc | |||
|
|
|||
| // Logging | |||
stevenh
force-pushed
the
chore/node-18
branch
from
e57266f
to
16ca434
Compare
Will do, was just fixing the spelling issues. I do wish we wouldn't keep getting random failures on some of the platforms. |
stevenh
force-pushed
the
chore/node-18
branch
2 times, most recently
from
991bd17
to
a5b9dbe
Compare
|
are the failures so random ? ^^ |
stevenh
force-pushed
the
chore/node-18
branch
from
a5b9dbe
to
0d39a9c
Compare
Add support for trace level debugging so we can reduce the spam while investigating issues for the log entries which are particularly large. Trace level logging can be enabled by add npm-groovy-lint-trace to the DEBUG environment variable.
stevenh
force-pushed
the
chore/node-18
branch
from
0d39a9c
to
60110a5
Compare
Yes it seems so, I'd say they currently fail more than succeed, from what I've seen while pushing up incremental fixes. |
|
There's a few ready for review now, will rebase the others when this is in as that will help identify any flaky behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the node 18 LTS so we're on a supported version.
Also updating a bunch of logging to help investigate the random failures occurring in workflows, including switching CodeNarcServer to use java logging instead of prints.