Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codenarc server logging overrides #332

Merged
merged 5 commits into from
Nov 27, 2023
Merged

codenarc server logging overrides #332

merged 5 commits into from
Nov 27, 2023

Conversation

mheiges
Copy link
Contributor

@mheiges mheiges commented Nov 27, 2023

Fixes

  • align log level property name in logback.xml with documentation

Proposed Changes

  • allow overriding the log fileName in logback.xml

@nvuillam
Copy link
Owner

Seems legit, but as I'm no java expert I prefer to wait for @stevenh 's opinion ^^

Note: if you want all the CI jobs to be green, just run npm run build then commit & push ^^

stevenh
stevenh approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement and good catch on the docs typo.

@stevenh stevenh merged commit 7ee8a97 into nvuillam:main Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mheiges @nvuillam @stevenh