Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update logback to 1.4.14 #336

Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore: update logback to 1.4.14 #336

merged 2 commits into from
Dec 6, 2023

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Dec 5, 2023

Update logback to 1.4.14 to address:
https://avd.aquasec.com/nvd/2023/cve-2023-6378/

Add library updating guide and expand existing details in CONTRIBUTING.md

Copy link

github-actions bot commented Dec 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ DOCKERFILE hadolint 1 0 0.51s
✅ GROOVY npm-groovy-lint 1 1 0 17.58s
✅ JAVASCRIPT eslint 100 0 0 5.26s
✅ JSON eslint-plugin-jsonc 9 0 0 2.26s
✅ JSON jsonlint 9 0 0.76s
✅ JSON npm-package-json-lint yes no 0.82s
✅ JSON prettier 9 2 0 1.9s
✅ JSON v8r 9 0 7.63s
✅ MARKDOWN markdownlint 7 2 0 4.21s
✅ MARKDOWN markdown-link-check 7 0 1.08s
✅ MARKDOWN markdown-table-formatter 7 2 0 0.81s
✅ REPOSITORY checkov yes no 14.73s
✅ REPOSITORY gitleaks yes no 8.76s
✅ REPOSITORY git_diff yes no 0.15s
✅ REPOSITORY grype yes no 16.15s
✅ REPOSITORY secretlint yes no 1.9s
✅ REPOSITORY trivy-sbom yes no 1.51s
✅ REPOSITORY trufflehog yes no 13.89s
✅ SPELL cspell 123 0 10.38s
✅ SPELL lychee 19 0 3.04s
✅ XML xmllint 1 0 0 0.1s
✅ YAML prettier 3 0 0 0.56s
✅ YAML v8r 3 0 10.27s
✅ YAML yamllint 3 0 0.47s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@stevenh stevenh force-pushed the chore/update-logback branch 2 times, most recently from 26033a4 to 60d9154 Compare December 5, 2023 11:53
@stevenh stevenh marked this pull request as draft December 5, 2023 12:13
Update logback to 1.4.14 to address:
https://avd.aquasec.com/nvd/2023/cve-2023-6378/

Add library updating guide and expand existing details in
CONTRIBUTING.md

Fixes #335
Docker hub is rate limiting GitHub sources causing 429 errors when
running megalinter, resulting in test failures so adding this URL to
.lycheeignore to avoid this failure.
@stevenh stevenh force-pushed the chore/update-logback branch 2 times, most recently from bb91c49 to 3484dc1 Compare December 5, 2023 18:46
@stevenh
Copy link
Collaborator Author

stevenh commented Dec 5, 2023

There's something strange going on with Windows tests, hanging once they are finished, but this latest test passed so will investigate more at another time.

@stevenh stevenh marked this pull request as ready for review December 5, 2023 21:13
@stevenh stevenh requested a review from nvuillam December 5, 2023 21:13
Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@nvuillam nvuillam merged commit 1dad1ba into main Dec 6, 2023
22 of 24 checks passed
@nvuillam nvuillam deleted the chore/update-logback branch December 6, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants