Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze Groovy files in folder fails #177

Closed
stevenh opened this issue Oct 18, 2023 · 1 comment · Fixed by #185
Closed

Analyze Groovy files in folder fails #177

stevenh opened this issue Oct 18, 2023 · 1 comment · Fixed by #185

Comments

@stevenh
Copy link
Collaborator

stevenh commented Oct 18, 2023

If you select the option to Analyze Groovy files in folder from the command pallet it fails as there's no folder selected.

[Error - 2:14:30 AM] Request workspace/executeCommand failed.
  Message: Request workspace/executeCommand failed with message: Cannot read properties of undefined (reading 'map')
  Code: -32603
stevenh added a commit to stevenh/vscode-groovy-lint that referenced this issue Oct 20, 2023
@stevenh
fix: Analyze Groovy files in folder
beaeb0f 
Fix Analyze Groovy files in folder which was always available resulting
in failures dependent on the context it was used.

It is now only available from a explorer folder.

Also correct the name of the parameter passed so explorer folder
requests work.

Fixes nvuillam#177
stevenh added a commit to stevenh/vscode-groovy-lint that referenced this issue Oct 20, 2023
@stevenh
fix: Analyze Groovy files in folder
02ca2ad 
Fix Analyze Groovy files in folder which was always available resulting
in failures dependent on the context it was used.

It is now only available from a explorer folder.

Also correct the name of the parameter passed so explorer folder
requests work.

Fixes nvuillam#177
stevenh added a commit to stevenh/vscode-groovy-lint that referenced this issue Oct 20, 2023
@stevenh
fix: Analyze Groovy files in folder
8fb0f24 
Fix Analyze Groovy files in folder which was always available resulting
in failures dependent on the context it was used.

It is now only available from a explorer folder.

Also correct the name of the parameter passed so explorer folder
requests work.

Fixes nvuillam#177
@stevenh stevenh mentioned this issue Oct 20, 2023
Closed
4 tasks
@stevenh
Copy link
Collaborator Author

stevenh commented Nov 28, 2023

Working on getting passing cleanly to validate this fix.

stevenh added a commit to stevenh/vscode-groovy-lint that referenced this issue Dec 11, 2023
@stevenh
fix: Analyze Groovy files in folder
db33842 
Fix Analyze Groovy files in folder which was always available resulting
in failures dependent on the context it was used.

It is now only available from a explorer folder.

Also correct the name of the parameter passed so explorer folder
requests work.

Fixes nvuillam#177
@stevenh stevenh mentioned this issue Dec 11, 2023
Merged
4 tasks
nvuillam pushed a commit that referenced this issue Dec 16, 2023
@stevenh
fix: various failures and issues (#185)
da683f3 
* fix: Analyze Groovy files in folder

Fix Analyze Groovy files in folder which was always available resulting
in failures dependent on the context it was used.

It is now only available from a explorer folder.

Also correct the name of the parameter passed so explorer folder
requests work.

Fixes #177

* fix: partial fixes never applying

Fix fixes in files which still have remaining issues not applying due to
the change in behaviour of npm-groovy-lint status code handling in
11.0.0 by now requesting failon: none.

* chore: improve debugging

Add more debugging so that its easier to understand what is happening.

Default debugging setting to that the DEBUG environment if set so that
the developer doesn't have to set it manually in settings when running a
debug session.

Also enable npm-groovy-lint debugging which is key to understanding
issues. While this was previous set for debugging sessions in the
environment the setting would always override it.

* ci: fix linting and update modules

Fix all the CI linting errors and update modules to address
vulnerabilities.

* chore: update client and server dependencies

Update all client and server dependencies to eliminate security issues.

* fix: random test failures

Refactor tests to be more reliable, making them independent
of each other, so if one test fails others are not effected. This
includes self managing timeouts as mocha doesn't handle pending
promises, which makes it harder to debug issues.

Run and Debug commands:
* Fix path to workspace files of "Language Server E2E Test" Run
  and Debug command.
* Rename to make it clear what each config is used for.

Add mochaExplorer configuration, to improve test visibility.

Re-enable big groovy test file, now it works as expected.

Rename test files to eliminate stuttering.

Fix test debugging by using NPM_DEBUG instead of DEBUG env var
which is filtered out by vscode, see:
microsoft/vscode#197494.

Remove duplicate lint call that's now handled by onDidChangeContent.

Remove fixed delay comment so we don't have to update when the delay
changes.

Update Node and JVM versions in README.md.

Update all packages, to address security issues and bring in
the latest version of npm-groovy-lint which includes a critical
race condition fix.

Clean up imports.

Use onDidChangeContent to trigger re-linting to improve
performance and remove skipNextOnDidChangeContents which
conflicts with this change.

Eliminate else statements where previous block returns,
to improve code readability.

Refactor resetDiagnostics into deleteDiagnostics as its now
only used for the delete flow, so we can remove unnecessary
logic and diagnostic changes.

Remove commented out code.

Convert high noise debugging to trace.

Add missing await to docManager.updateDocumentSettings call

Use latest xvfb-action@v1 instead of v1.0 to bring in the latest
fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@stevenh