Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new settings option to show problems panel after initial pass #183

Merged

Conversation

NecroKote
Copy link
Contributor

Proposed Changes

  1. new settings option showProblemsView to control if Problems View should be opened after initial lint pass

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Owner

@NecroKote is this PR still applicable ?

If yes, please can you merge main in your branch to make it up to date ?

Mikalai Kukhta added 3 commits December 17, 2023 18:55
It controls if Problems View should open once after initial lint pass
@NecroKote NecroKote force-pushed the feature/settings-option-to-show-problems branch from 88415c1 to 8a60f2a Compare December 17, 2023 17:56
@NecroKote
Copy link
Contributor Author

NecroKote commented Dec 17, 2023

Hi @nvuillam,
I've rebased my changes on your fresh main.

Initially, I targeted the upgrade branch as at that time it contained the "latest" changes.

@NecroKote NecroKote changed the base branch from upgrade to main December 17, 2023 17:59
@nvuillam nvuillam force-pushed the feature/settings-option-to-show-problems branch from d13a37f to c5acf10 Compare December 17, 2023 18:42
Copy link
Owner

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thanks for your contribution :)

@nvuillam nvuillam merged commit 88b16bf into nvuillam:main Dec 17, 2023
1 of 2 checks passed
@nvuillam
Copy link
Owner

@NecroKote it's released in 3.1.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants