fix: file end of line character changes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
fix/maintain-file-eol
branch
6 times, most recently
from
59a78fc
to
5b5451a
Compare
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. This only handles Unix '\n' and Windows '\r\n' line endings, not pre MacOSX Mac '\r' as CodeNar doesn't appear to support that line ending. Fix callback handling in tests, adding missing await and reject handling. Validate each file result in folder lint test instead of total. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
Disable mega linter generation of commits to repo forks as this will generally fail.
stevenh
force-pushed
the
fix/maintain-file-eol
branch
from
5b5451a
to
ab11772
Compare
nvuillam
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead.
Fix callback handling in tests, adding missing await and reject handling.
Use option chaining and early return in getUpdatedSource to improve readability.
Remove use of deprecated isNullOrUndefined.
Disable mega linter commits to forks, which will fail anyway.
Fixes #176
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance