Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are the minimum required to make FileKit work with Swift 3. This means that the following were not changed, but perhaps should be addressed in a future pull request before a final 4.0 release:
public
to the now equivalentopen
and similarlyprivate
tofileprivate
, though perhaps the newpublic
andprivate
would be more appropriate in some situationsfunc symlinkFileToPath(path: Path)
was changed tofunc symlinkFileToPath(_ path: Path)
, while perhaps its eventual name should befunc symlinkFile(to path: Path)
While these could be addressed in this pull request, I believe they would be better served by a future one.
The only consideration left in this pull request is
Path
's conformance toIndexable
. For a reason I could not deduce, Swift 3 throws errors whenPath
conforms to bothIndexable
andSequence
, so in this pull request I removed conformance toIndexable
in order to fix the errors. TheIndexable
conformance is not actually utilized anywhere, so I think it would be best to just remove it, but I'm happy to do whatever you think is best in this situation.