Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for changing GTK theme #58

Merged
merged 1 commit into from Mar 18, 2022
Merged

Support for changing GTK theme #58

merged 1 commit into from Mar 18, 2022

Conversation

jovanlanik
Copy link
Contributor

This pull request adds an argument to change the GTK theme. Unlike changing the theme with environment variables or gsettings, the change doesn't effect other applications.
I added the same functionality to nwg-launchers (nwg-piotr/nwg-launchers#200) but now I use sway with nwg-drawer and would like to see it merged here.
It's my first time working in go, I hope the code is ok. I tested this on sway for 4 days and had no issues.

@nwg-piotr
Copy link
Owner

Interesting. Could you tell me more about the use case? Personally I see no use on my machine, but it could be merged immediately, even if not yet released. I can't make my mind if to accept two other pending PRs, or to reject them.

@jovanlanik
Copy link
Contributor Author

Well, my use case is that I want nwg-drawer to always use Adwaita-dark regardless of gsettings, but I want other apps (including those that are launched by nwg-drawer) to respect gsettings. I can't use the GTK_THEME environmental variable because it affects launched apps.
I can also see use on systems which have automatic dark theme switching. If you have custom css for nwg-drawer it's probably based around one theme, so you'd want to prevent automatic switching by ignoring gsettings and always use the right theme.

@nwg-piotr
Copy link
Owner

Perfect explanation, thanks!

@nwg-piotr nwg-piotr merged commit e052a86 into nwg-piotr:main Mar 18, 2022
@jovanlanik
Copy link
Contributor Author

@nwg-piotr Thank you for merging. Would you be open to adding the same feature to other nwg-shell programs? I think the same reasoning applies.

@nwg-piotr
Copy link
Owner

Yes, good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants