Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for userlist #3

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Fix for userlist #3

merged 3 commits into from
Dec 29, 2023

Conversation

kragebein
Copy link

This works for me that doesnt have any local users (FreeIPA/Active Directory setup). Would also work for local users.

Copy link
Owner

@nwg-piotr nwg-piotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's going to filter out the ftp user on Slackware. It does have their home dir. Am I wrong?

@nwg-piotr
Copy link
Owner

image

@kragebein
Copy link
Author

kragebein commented Dec 28, 2023

Okay, i've created a check that checks /etc/login.defs to ensure we only get human like users (except root).
The ftp user had something like uid 14 and shouldnt pop up.

Any users with uid lower than 1000 should not make the cut.

But the application will still fail if the userlist still comes back empty (e.g, a user hasnt logged in for the first time yet), in that case it would crash back to terminal. So in any case the user list comes back empty, the drop down field should be replaced with a text field where the user can type in their username instead.

@nwg-piotr
Copy link
Owner

But the application will still fail if the userlist still comes back empty (...)

This should never happen, unless someone creates a new user w/o the -m argument. For sure not on nwg-iso, which the greeter was written for. Users created during installation have their home dirs and are visible on the 1st run.

@nwg-piotr nwg-piotr merged commit 510be57 into nwg-piotr:main Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants