Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons do not break nicely if the requested size is bigger than maximum #188

Closed
Siborgium opened this issue Sep 30, 2021 · 0 comments · Fixed by #189
Closed

Icons do not break nicely if the requested size is bigger than maximum #188

Siborgium opened this issue Sep 30, 2021 · 0 comments · Fixed by #189
Assignees
@Siborgium

Comments

@Siborgium
Copy link
Collaborator

Icons do not break nicely if I request size bigger than maximum:

-s 2160:

2021-09-29_14-09-1632940342_screenshot

Is this the expected behavior? I would expect it to either default to the maximum (2048) or show nothing but some kind of error message.

Originally posted by @Figuera in #180 (comment)
@Siborgium Siborgium self-assigned this Sep 30, 2021
Siborgium added a commit that referenced this issue Sep 30, 2021
@Siborgium
Saturate icon size if it's off the allowed range (16-2048).
87c3722 
Fixes: #188

Saturating is done as follows:

    size < 16   -> size = 16
    size > 2048 -> size = 2048
@Siborgium Siborgium mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siborgium Siborgium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Saturate icon size if it's off the allowed range (16-2048). nwg-piotr/nwg-launchers
1 participant
@Siborgium