Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwayTaskBar doesn't show icons for some apps that use "reverse DNS" style #64

Closed
CIAvash opened this issue Jul 25, 2021 · 12 comments · Fixed by #65
Closed

SwayTaskBar doesn't show icons for some apps that use "reverse DNS" style #64

CIAvash opened this issue Jul 25, 2021 · 12 comments · Fixed by #65

Comments

@CIAvash
Copy link

CIAvash commented Jul 25, 2021

For example, Cawbird has icon uk.co.ibboard.cawbird, but its icon is not shown.

@nwg-piotr
Copy link
Owner

nwg-piotr commented Jul 25, 2021

Couldn't confirm. Could you show me your usr/share/applications/uk.co.ibboard.cawbird.desktop file content? Also - tell me more about your system.

obraz

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

[Desktop Entry]
Name[ar]=كوربرد
Name[ast]=Cawbird
Name[ca]=Cawbird
Name[da]=Cawbird
Name[de]=Cawbird
Name[de_DE]=Cawbird
Name[en_GB]=Cawbird
Name[eo]=Cawbird
Name[es]=Cawbird
Name[es_419]=Cawbird
Name[fi]=Cawbird
Name[fr]=Cawbird
Name[ga]=Cawbird
Name[gd]=Cawbird
Name[gl]=Cawbird
Name[id]=Cawbird
Name[it]=Cawbird
Name[ja]=Cawbird
Name[ko]=코어버드
Name[lt]=Cawbird
Name[nb]=Cawbird
Name[nl]=Cawbird
Name[pl]=Cawbird
Name[pt]=Cawbird
Name[pt_BR]=Cawbird
Name[ru]=Cawbird
Name[sr]=Корберд
Name[sr_BA@latin]=Cawbird
Name[zh_CN]=Cawbird
Name[zh_TW]=Cawbird
Name=Cawbird
GenericName[ar]=عميل تويتر
GenericName[ast]=Veceru pa Twitter
GenericName[ca]=Client del Twitter
GenericName[ca@valencia]=Client del Twitter
GenericName[da]=Twitter klient
GenericName[de]=Twitter Client
GenericName[de_DE]=Twitter Client
GenericName[en_GB]=Twitter Client
GenericName[eo]=Tviterokliento
GenericName[es]=Cliente Twitter
GenericName[es_419]=Cliente de Twitter
GenericName[es_MX]=Cliente de Twitter
GenericName[es_VE]=Cliente de Twitter
GenericName[fi]=Twitter-sovellus
GenericName[fr]=Client Twitter
GenericName[gd]=Cliant Twitter
GenericName[gl]=Cliente para o Twitter
GenericName[hu]=Twitter kliens
GenericName[id]=Twitter Klien
GenericName[it]=Client Twitter
GenericName[ja]=Twitter Client
GenericName[ko]=트위터 클라이언트
GenericName[lt]=Twitter klientas
GenericName[nb]=Twitter-klient
GenericName[nl]=Twittertoepassing
GenericName[pl]=Klient Twittera
GenericName[pt]=Cliente de Twitter
GenericName[pt_BR]=Cliente Twitter
GenericName[ro]=Client Twitter
GenericName[ru]=Клиент для Твиттера
GenericName[sr]=Твитер клијент
GenericName[sr_BA@latin]=Twitter klijent
GenericName[tr]=Twitter İstemcisi
GenericName[uk_UA]=Twitter-клієнт
GenericName[zh_CN]=Twitter 客户端
GenericName[zh_TW]=Twitter用戶端
GenericName=Twitter Client
Comment[ar]=استحدم تويتر من داخل تطبيق في سطح المكتب. 
Comment[ast]=Usa Twitter dende una aplicación d'escritoriu normal
Comment[ca]=Utilitza Twitter en una aplicació d'escriptori normal
Comment[da]=Brug Twitter i en desktop applikation
Comment[de]=Nutzen Sie Twitter in einer normalen Desktopanwendung
Comment[de_DE]=Nutzen Sie Twitter in einer normalen Desktopanwendung
Comment[en_GB]=Use Twitter from within a normal desktop application
Comment[eo]=Uzi Tviteron simila al normala komputerprogramo
Comment[es]=Usa Twitter desde una aplicación de escritorio normal
Comment[fi]=Käytä Twitteriä tavallisella työpöytäsovelluksella
Comment[fr]=Utiliser Twitter depuis une application de bureau classique
Comment[gd]=Cleachd Twitter am broinn aplacaid deasga àbhaisteach
Comment[gl]=Use Twitter desde un aplicativo de escritorio
Comment[id]=Gunakan Twitter dari aplikasi desktop normal
Comment[it]=Usa Twitter come una normale applicazione desktop
Comment[ja]=通常のデスクトップアプリケーションからTwitterを使用する
Comment[ko]=일반 데스크탑 앱에서 트위터 사용하기
Comment[lt]=Naudokitės Twitter normalioje darbalaukio programoje
Comment[nb]=Bruk Twitter som et vanlig skrivebordsprogram
Comment[nl]=Gebruik Twitter vanuit een normale bureaubladtoepassing
Comment[pl]=Korzystanie z Twittera w zwykłym programie
Comment[pt]=Usar o Twitter de uma aplicação de desktop normal
Comment[pt_BR]=Use o Twitter de um aplicativo desktop normal
Comment[ru]=Пользуйтесь Твиттером как обычным приложением
Comment[sr]=Користите Твитер помоћу обичног рачунарског програма
Comment[sr_BA@latin]=Koristite Twitter pomoću običnog računarskog programa
Comment[zh_CN]=桌面应用般的 Twitter 使用体验
Comment[zh_TW]=在普通的桌面應用程式內使用 Twitter
Comment=Use Twitter from within a normal desktop application
# TRANSLATORS: Search terms to find this application. Do NOT translate or localize the semicolons! The list MUST also end with a semicolon!
Keywords[ar]=تويتر;
Keywords[ast]=twitter;
Keywords[ca]=twitter;
Keywords[da]=twitter;
Keywords[de]=twitter;
Keywords[de_DE]=twitter;
Keywords[en_GB]=twitter;
Keywords[eo]=twitter;tvitero;
Keywords[es]=twitter;
Keywords[fi]=twitter;
Keywords[fr]=twitter;
Keywords[gd]=twitter;
Keywords[gl]=twitter;
Keywords[id]=twitter;
Keywords[it]=Twitter;
Keywords[ko]=트위터;
Keywords[lt]=twitter;
Keywords[nb]=twitter;
Keywords[nl]=twitter;
Keywords[pl]=twitter;
Keywords[pt]=twitter;
Keywords[pt_BR]=twitter:
Keywords[ru]=twitter;
Keywords[sr]=twitter;tviter;твитер;
Keywords[sr_BA@latin]=twitter;tviter;tviter;
Keywords[zh_CN]=twitter;
Keywords[zh_TW]=twitter;
Keywords=twitter;
Exec=cawbird
Type=Application
# TRANSLATORS: Do NOT translate or transliterate this text (this is an icon file name)!
Icon=uk.co.ibboard.cawbird
Categories=Network;GTK;
DBusActivatable=true
StartupWMClass=cawbird
# TRANSLATORS: Do NOT translate or transliterate this text (these are enum types)!
X-Purism-FormFactor=Workstation;Mobile;

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

Also - tell me more about your system.

Arch Linux with Sway window manager. Linux 5.13.4-arch2-1.

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

When I add a custom button to the panel with icon uk.co.ibboard.cawbird, it shows the icon.

@nwg-piotr
Copy link
Owner

nwg-piotr commented Jul 26, 2021

The file is absolutely the same as mine, and I'm on Arch, too. Are you sure your panel is up to date? The latest fixes regarding icons were done in v0.3.2. The current version is 0.4.0.

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

Yes, actually I don't think I had this problem before, otherwise I would mention it in my previous issues. That's weird.

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

For me, Cawbird's app_id is "cawbird" not "uk.co.ibboard.cawbird", could that be the cause?

@nwg-piotr
Copy link
Owner

nwg-piotr commented Jul 26, 2021

What we only know about a certain task is its app_id or wm_class. The module first looks for the app_id_value.desktop or wm_class_value.desktop file, and in this case does not find it. We only consider the file name, not its content, as opening and parsing all the .desktop files would affect the startup time. If no matching .desktop file found, the module tries to create the icon from the known name, and it works for me, but does not work for you. Possibly another icon theme would change the situation on your side. I don't think we can do much about it on the code level.

Possible workaround:

  1. copy uk.co.ibboard.cawbird.desktop to ~/.local/share/applications;
  2. rename the copied file to cawbird.desktop;

To avoid duplicate entry in launchers:

  1. copy uk.co.ibboard.cawbird.desktop to ~/.local/share/applications again;
  2. open the copy, add NoDisplay=true inside the [Desktop Entry] section.

@CIAvash
Copy link
Author

CIAvash commented Jul 26, 2021

OK.

@CIAvash CIAvash closed this as completed Jul 26, 2021
@nwg-piotr
Copy link
Owner

Let's try a programmatic solution, though.

@nwg-piotr
Copy link
Owner

Could you build from the "images" branch and tell me if it helps?

@CIAvash
Copy link
Author

CIAvash commented Jul 27, 2021

Yeah, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants