Skip to content

Commit

Permalink
Revert of Revert of Remove unneeded DocumentLoader null check in Wind…
Browse files Browse the repository at this point in the history
…owProxy. (patchset #1 id:1 of https://codereview.chromium.org/794113005/)

Reason for revert:
The revert broke compilation everywhere.

Original issue's description:
> Revert of Remove unneeded DocumentLoader null check in WindowProxy. (patchset #1 id:1 of https://codereview.chromium.org/797483003/)
> 
> Reason for revert:
> Test plugins/js-from-destroy.html starts crashing on Mac.
> Flakiness Dashboard: http://goo.gl/YID0Ti
> 
> Original issue's description:
> > Remove unneeded DocumentLoader null check in WindowProxy.
> > 
> > BUG=none
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186983
> 
> TBR=haraken@chromium.org,dcarney@chromium.org,dcheng@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187020

TBR=haraken@chromium.org,dcarney@chromium.org,dcheng@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/804483002

git-svn-id: svn://svn.chromium.org/blink/trunk@187021 bbb929c8-8fbe-4397-9dbb-9b2b20218538
  • Loading branch information
aslushnikov committed Dec 12, 2014
1 parent c649a5a commit 44fba12
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Source/bindings/core/v8/WindowProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,6 @@ bool WindowProxy::initialize()

void WindowProxy::createContext()
{
// The documentLoader pointer could be 0 during frame shutdown.
// FIXME: Can we remove this check?
if (!m_frame->loader().documentLoader())
return;

// Create a new environment using an empty template for the shadow
// object. Reuse the global object if one has been created earlier.
v8::Handle<v8::ObjectTemplate> globalTemplate = V8Window::getShadowObjectTemplate(m_isolate);
Expand Down

0 comments on commit 44fba12

Please sign in to comment.