Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix WebRequestProxyingURLLoaderFactory crash after redirect
When OnReceiveRedirect() is called, we expect to not receive any more events for that request until FollowRedirect() has been called and the request is restarted with the new URL. We were not clearing the bindings in this case, so the URLLoader was staying alive and calling OnBeforeSendHeaders() on the redirected URL. This could then result in OnBeforeSendHeaders() being called twice, once for the original request which gets redirected in //net, and once for the request in the correct flow when it gets restarted after FollowRedirect(). I believe this is pretty similar to the issue described in http://crbug.com/882661, except this one has to do with normal redirects instead of webRequest generated redirects. The existing redirect tests catch this issue when using the 'extraHeaders' spec, so I made a version of them that runs with that enabled. Bug: 918761 Change-Id: Ifa551400e85c13ea3a297fba02a05deb5ccb1821 Reviewed-on: https://chromium-review.googlesource.com/c/1409915 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#622685}
- Loading branch information