Skip to content

Commit

Permalink
Experimentally removing MSAA workaround for perf bot
Browse files Browse the repository at this point in the history
The perf bot perf.chromium-rel-mac12 has alerted on a ~50% slowdown in
http___webglsamples.org_dynamic-cubemap_dynamic-cubemap.html .
In the regression range was my seemingly closely
related CL: https://crrev.com/c/923103
But that commit should improve performance, not regress it.

So this CL adds an exception to the workaround in 923103, so that
that workaround does not apply on perf.chromium-rel-mac12.
This should help determine whether my CL really caused a regression.

I'm expecting this CL to cause a regression in
http___kenrussell.github.io_webgl-animometer_Animometer_tests_3d_webgl.html
(undoing the recent improvement caused by 923103).

Bug: 815154
Change-Id: I335133a127bb7cfcb92ba29065641dfd55b63166
Reviewed-on: https://chromium-review.googlesource.com/938844
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540237}
  • Loading branch information
kainino0x authored and Commit Bot committed Mar 1, 2018
1 parent a7eba85 commit 23b2d93
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 0 deletions.
30 changes: 30 additions & 0 deletions content/test/gpu/gpu_tests/pixel_expectations.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,33 @@ def SetExpectations(self):

self.Fail('Pixel_CSSFilterEffects', ['mac'], bug=815045)
self.Fail('Pixel_CSSFilterEffects_NoOverlays', ['mac'], bug=815045)

# TODO(kainino): temporary suppressions for perf experiment
self.Fail('Pixel_2DCanvasWebGL',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_IOSurface2DCanvasWebGL',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasTransferAfterStyleResize',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasTransferBeforeStyleResize',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasWebGLDefault',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasWebGLDefaultWorker',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasWebGLSoftwareCompositing',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasWebGLSoftwareCompositingWorker',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_OffscreenCanvasWebglResizeOnWorker',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_WebGLGreenTriangle_AA_Alpha',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_WebGLGreenTriangle_AA_Alpha_SwiftShader',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_WebGLGreenTriangle_AA_NoAlpha',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_WebGLGreenTriangle_NonChromiumImage_AA_Alpha',
['mac', 'intel'], bug=815154)
self.Fail('Pixel_WebGLGreenTriangle_NonChromiumImage_AA_NoAlpha',
['mac', 'intel'], bug=815154)
7 changes: 7 additions & 0 deletions gpu/config/gpu_driver_bug_list.json
Original file line number Diff line number Diff line change
Expand Up @@ -2777,6 +2777,13 @@
"os": {
"type": "macosx"
},
"exceptions" : [
{
"comment": "TODO(kainino): testing whether this CL is really responsible for crbug.com/815154",
"vendor_id": "0x8086",
"device_id": ["0x0a2e"]
}
],
"vendor_id": "0x8086",
"multi_gpu_category": "primary",
"features": [
Expand Down

0 comments on commit 23b2d93

Please sign in to comment.