Upload EIDs as bytes.

Formally changed the type in the proto (as on server). Also include
a zero byte in the EID in unit tests.

BUG=chromium:840496
TEST=unit_tests

Change-Id: I4e0acaf70547658421c16a8d4731f72f7dc2caa1
Reviewed-on: https://chromium-review.googlesource.com/1079255
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563024}

chrome/browser/chromeos/attestation/enrollment_policy_observer.cc

@@ -187,10 +187,14 @@ void EnrollmentPolicyObserver::GetEnrollmentId() {
 
 void EnrollmentPolicyObserver::HandleEnrollmentId(
     const std::string& enrollment_id) {
+  if (enrollment_id.empty()) {
+    LOG(WARNING) << "EnrollmentPolicyObserver: The enrollment identifier"
+                    " obtained is empty.";
+  }
   policy_client_->UploadEnterpriseEnrollmentId(
       enrollment_id,
-      base::Bind(&EnrollmentPolicyObserver::OnUploadComplete,
-                 weak_factory_.GetWeakPtr(), "Enrollment Identifier"));
+      base::BindRepeating(&EnrollmentPolicyObserver::OnUploadComplete,
+                          weak_factory_.GetWeakPtr(), "Enrollment Identifier"));
 }
 
 void EnrollmentPolicyObserver::RescheduleGetEnrollmentId() {

chrome/browser/chromeos/attestation/enrollment_policy_observer_unittest.cc

@@ -11,6 +11,7 @@
 #include "base/location.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/chromeos/attestation/enrollment_policy_observer.h"
 #include "chrome/browser/chromeos/settings/device_settings_test_helper.h"
@@ -61,17 +62,18 @@ class EnrollmentPolicyObserverTest : public DeviceSettingsTestBase {
  public:
   EnrollmentPolicyObserverTest() {
     policy_client_.SetDMToken("fake_dm_token");
+
+    std::vector<uint8_t> eid;
+    EXPECT_TRUE(base::HexStringToBytes(kEnrollmentId, &eid));
+    enrollment_id_.assign(reinterpret_cast<const char*>(eid.data()),
+                          eid.size());
+    cryptohome_client_.set_tpm_attestation_enrollment_id(
+        true /* ignore_cache */, enrollment_id_);
   }
 
  protected:
   static constexpr char kEnrollmentId[] =
-      "6fcc0ebddec3db95cdcf82476d594f4d60db934c5b47fa6085c707b2a93e205b";
-
-  void SetUp() override {
-    DeviceSettingsTestBase::SetUp();
-    cryptohome_client_.set_tpm_attestation_enrollment_id(
-        true /* ignore_cache */, kEnrollmentId);
-  }
+      "6fcc0ebddec3db9500cf82476d594f4d60db934c5b47fa6085c707b2a93e205b";
 
   void SetUpEnrollmentIdNeeded(bool enrollment_id_needed) {
     if (enrollment_id_needed) {
@@ -103,6 +105,7 @@ class EnrollmentPolicyObserverTest : public DeviceSettingsTestBase {
   FakeCryptohomeClient cryptohome_client_;
   StrictMock<MockAttestationFlow> attestation_flow_;
   StrictMock<policy::MockCloudPolicyClient> policy_client_;
+  std::string enrollment_id_;
 };
 
 constexpr char EnrollmentPolicyObserverTest::kEnrollmentId[];
@@ -132,7 +135,7 @@ TEST_F(EnrollmentPolicyObserverTest, GetCertificateUnspecifiedFailure) {
 TEST_F(EnrollmentPolicyObserverTest, GetCertificateBadRequestFailure) {
   EXPECT_CALL(attestation_flow_, GetCertificate(_, _, _, _, _))
       .WillOnce(WithArgs<4>(Invoke(CertCallbackBadRequestFailure)));
-  EXPECT_CALL(policy_client_, UploadEnterpriseEnrollmentId(kEnrollmentId, _))
+  EXPECT_CALL(policy_client_, UploadEnterpriseEnrollmentId(enrollment_id_, _))
       .WillOnce(WithArgs<1>(Invoke(StatusCallbackSuccess)));
   SetUpDevicePolicy(true);
   Run();

components/policy/proto/device_management_backend.proto

@@ -213,7 +213,7 @@ message DeviceCertUploadRequest {
   // Type of certificate. If omitted, will be guessed from the other fields.
   optional CertificateType certificate_type = 2;
   // Enrollment identifier if provided.
-  optional string enrollment_id = 3;
+  optional bytes enrollment_id = 3;
 }
 
 // Response from server to device for cert upload request.