Skip to content

Commit

Permalink
Fix useless DCHECK in URLFetcherCore::StartURLRequest
Browse files Browse the repository at this point in the history
The DCHECK on the pointer being non-null could be never hit,
as the pointer was dereferenced a couple of lines above.

BUG=none
TEST=existing tests

Review-Url: https://codereview.chromium.org/2732473003
Cr-Commit-Position: refs/heads/master@{#454471}
  • Loading branch information
emaxx authored and Commit bot committed Mar 3, 2017
1 parent 78fa524 commit 939b32e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/url_request/url_fetcher_core.cc
Original file line number Diff line number Diff line change
Expand Up @@ -540,12 +540,12 @@ void URLFetcherCore::StartURLRequest() {
return;
}

DCHECK(request_context_getter_);
if (!request_context_getter_->GetURLRequestContext()) {
CancelRequestAndInformDelegate(ERR_CONTEXT_SHUT_DOWN);
return;
}

DCHECK(request_context_getter_.get());
DCHECK(!request_.get());

g_registry.Get().AddURLFetcherCore(this);
Expand Down

0 comments on commit 939b32e

Please sign in to comment.