Skip to content

Commit

Permalink
[vr] Fix shadow offsets
Browse files Browse the repository at this point in the history
Gives the omnibox a soft shadow.

Bug: 833375
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2
Reviewed-on: https://chromium-review.googlesource.com/1014010
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551010}
  • Loading branch information
Ian Vollick authored and Commit Bot committed Apr 16, 2018
1 parent 1b57825 commit a9741a3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion chrome/browser/vr/ui_scene_creator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2423,7 +2423,7 @@ void UiSceneCreator::CreateOmnibox() {
e->SetTransitionedProperties({});
y_offset += kUrlBarVerticalOffsetDMM;
}
e->SetTranslate(0, y_offset, kOmniboxShadowOffset);
e->SetTranslate(0, y_offset, -kOmniboxShadowOffset);
},
shadow.get())));

Expand Down Expand Up @@ -2631,6 +2631,7 @@ void UiSceneCreator::CreateOmnibox() {
omnibox_background->set_hit_testable(true);
omnibox_background->set_focusable(false);
omnibox_background->set_corner_radius(kOmniboxCornerRadiusDMM);
omnibox_background->SetTranslate(0, 0, kOmniboxShadowOffset);
VR_BIND_COLOR(model_, omnibox_background.get(),
&ColorScheme::omnibox_background, &Rect::SetColor);
omnibox_background->AddChild(std::move(omnibox_outer_layout));
Expand Down

0 comments on commit a9741a3

Please sign in to comment.