Skip to content

Commit

Permalink
Disable ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbed.
Browse files Browse the repository at this point in the history
This is the sister test to ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbedObject. Both of them are incompatible with preloading HSTS for youtube.com as written.

Bug: 771338
Change-Id: I6d3357cbbd3ae978721e0e7c7cafd9410c274db9
Reviewed-on: https://chromium-review.googlesource.com/722448
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509734}
  • Loading branch information
lgarron authored and Commit Bot committed Oct 18, 2017
1 parent a4b38e4 commit bf632cf
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,10 @@ class ChromeContentRendererClientBrowserTest :
scoped_refptr<content::MessageLoopRunner> message_runner_;
};

// TODO(crbug.com/771338): This test needs to be rewritten to work with
// preloaded HSTS for youtube.com
IN_PROC_BROWSER_TEST_P(ChromeContentRendererClientBrowserTest,
RewriteYouTubeFlashEmbed) {
DISABLED_RewriteYouTubeFlashEmbed) {
GURL url(embedded_test_server()->GetURL("/flash_embeds.html"));
ui_test_utils::NavigateToURL(browser(), url);
content::WebContents* web_contents =
Expand Down

0 comments on commit bf632cf

Please sign in to comment.