-
Notifications
You must be signed in to change notification settings - Fork 128
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Autofill Assistant] Fix bug in ShowDetailsAction.
Before this patch, users selecting "Go Back" when asked to confirm inconsistent details caused a crash. This was caused by std::move being called twice on the same callback. This patch gets rid of the crash by keeping the callback in the action instance instead of the individual callbacks. Bug: 806868 Change-Id: I6f8520e4f3b97bed40369cc95f19c5d2e763f95f Reviewed-on: https://chromium-review.googlesource.com/c/1442651 Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#626978}
- Loading branch information
Stephane Zermatten
authored and
Commit Bot
committed
Jan 29, 2019
1 parent
7fe13bd
commit c5c8dab
Showing
2 changed files
with
16 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters